Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1973)

Issue 6948058: Add dead-is-alive boolean property to Hara_kiri_group_spanner (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by dak
Modified:
8 years, 9 months ago
Reviewers:
Keith, lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Add dead-is-alive boolean property to Hara_kiri_group_spanner This reverses the decisions that the Hara_kiri_engraver makes. Particularly in connection with the Keep_alive_together_engraver, this allows for per-line content-based switching between alternative staff displays.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M lily/hara-kiri-group-spanner.cc View 2 chunks +6 lines, -3 lines 1 comment Download
M scm/define-grob-properties.scm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9
lemzwerg
LGTM. Do we have a regtest (or rather, an example) which demonstrates how to use ...
11 years, 4 months ago (2012-12-15 10:48:12 UTC) #1
dak
On 2012/12/15 10:48:12, lemzwerg wrote: > LGTM. Do we have a regtest (or rather, an ...
11 years, 4 months ago (2012-12-15 11:40:17 UTC) #2
Keith
https://codereview.appspot.com/6948058/diff/1/lily/hara-kiri-group-spanner.cc File lily/hara-kiri-group-spanner.cc (right): https://codereview.appspot.com/6948058/diff/1/lily/hara-kiri-group-spanner.cc#newcode80 lily/hara-kiri-group-spanner.cc:80: bool in_Hades = to_boolean (me->get_property ("dead-is-alive")); The flag, used ...
11 years, 4 months ago (2012-12-15 18:22:35 UTC) #3
Keith
On 2012/12/15 11:40:17, dak wrote: > > I was sort of hoping that Keith would ...
11 years, 4 months ago (2012-12-15 18:22:46 UTC) #4
dak
On 2012/12/15 18:22:46, Keith wrote: [...] > A re-arrangement in logic could give a useful ...
11 years, 4 months ago (2012-12-15 21:32:41 UTC) #5
Keith
On 2012/12/15 21:32:41, dak wrote: > The "dead-is-alive"-thing had the > advantage that even though ...
11 years, 4 months ago (2012-12-16 04:15:41 UTC) #6
dak
k-ohara5a5a@oco.net writes: > On 2012/12/15 21:32:41, dak wrote: >> The "dead-is-alive"-thing had the >> advantage ...
11 years, 4 months ago (2012-12-16 08:09:38 UTC) #7
Keith
On 2012/12/16 08:09:38, dak wrote: > Well, the idea was to use this in pairs ...
11 years, 4 months ago (2012-12-17 06:13:22 UTC) #8
dak
11 years, 4 months ago (2012-12-17 08:22:51 UTC) #9
On 2012/12/17 06:13:22, Keith wrote:
> On 2012/12/16 08:09:38, dak wrote:

> That works fine.  The input below will show a single staff, except for the one
> line containing the voice-crossing section, regardless of where the
line-breaks
> fall. (We can do this with current LilyPond using two Staff contexts; the new
> feature enables the measure that could be printed either as chords or divided
> staves, depending on linebreaks.)
> 
> The problems with 'dead-is-alive' are the difficulty of keeping track of the
> reversed logic, and loss of the usual action of removeEmptyStaves when all
> affected staves are truly empty.

Ok, so we should likely not be abusing the keepAliveInterfaces as
keepDeadInterfaces as it may be separately needed.  Instead we likely want
something like a killContexts list which names a number of contexts to kill if
this context is not suicided (or already killed) itself.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b