Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(35)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 6947046: code review 6947046: runtime/race: update runtime to r170112. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by dvyukov
Modified:
11 years, 4 months ago
Reviewers:
minux1
CC:
golang-dev, bradfitz, rsc, remyoudompheng
Visibility:
Public.

Description

runtime/race: update runtime to r170112. This includes GORACE history_size and log_path flags.

Patch Set 1 #

Patch Set 2 : diff -r 89e5cabaa09a https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 89e5cabaa09a https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r ee5afd4b14b7 https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
M src/pkg/runtime/race/race_darwin_amd64.syso View 1 Binary file 0 comments Download
M src/pkg/runtime/race/race_windows_amd64.syso View 1 Binary file 0 comments Download

Messages

Total messages: 13
dvyukov
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
11 years, 4 months ago (2012-12-13 18:07:33 UTC) #1
bradfitz
maybe include some JPEGs with this CL too? On Thu, Dec 13, 2012 at 10:07 ...
11 years, 4 months ago (2012-12-13 18:21:03 UTC) #2
dvyukov
hummm... cats? On Thu, Dec 13, 2012 at 10:21 PM, Brad Fitzpatrick <bradfitz@golang.org> wrote: > ...
11 years, 4 months ago (2012-12-13 18:26:05 UTC) #3
rsc
LGTM
11 years, 4 months ago (2012-12-13 21:20:16 UTC) #4
remyoudompheng
It is revision r170112 of what ? Rémy.
11 years, 4 months ago (2012-12-13 23:05:32 UTC) #5
minux1
On Fri, Dec 14, 2012 at 7:05 AM, Rémy Oudompheng <remyoudompheng@gmail.com>wrote: > It is revision ...
11 years, 4 months ago (2012-12-13 23:08:22 UTC) #6
remyoudompheng
On 2012/12/14 minux <minux.ma@gmail.com> wrote: > > On Fri, Dec 14, 2012 at 7:05 AM, ...
11 years, 4 months ago (2012-12-13 23:34:02 UTC) #7
minux1
On Fri, Dec 14, 2012 at 7:34 AM, Rémy Oudompheng <remyoudompheng@gmail.com>wrote: > How do I ...
11 years, 4 months ago (2012-12-13 23:39:04 UTC) #8
dvyukov
On 2012/12/13 23:05:32, remyoudompheng wrote: > It is revision r170112 of what ? > > ...
11 years, 4 months ago (2012-12-14 09:18:06 UTC) #9
dvyukov
On 2012/12/13 23:34:02, remyoudompheng wrote: > On 2012/12/14 minux <mailto:minux.ma@gmail.com> wrote: > > > > ...
11 years, 4 months ago (2012-12-14 09:19:12 UTC) #10
dvyukov
*** Submitted as https://code.google.com/p/go/source/detail?r=a9edbc33dcee *** runtime/race: update runtime to r170112. This includes GORACE history_size and ...
11 years, 4 months ago (2012-12-14 09:24:35 UTC) #11
minux1
On 2012/12/14 09:24:35, dvyukov wrote: > *** Submitted as https://code.google.com/p/go/source/detail?r=a9edbc33dcee Hi, I wonder why Patch ...
11 years, 4 months ago (2012-12-14 09:31:00 UTC) #12
dvyukov
11 years, 4 months ago (2012-12-14 09:41:17 UTC) #13
Message was sent while issue was closed. 
On 2012/12/14 09:31:00, minux wrote:
> On 2012/12/14 09:24:35, dvyukov wrote:
> > *** Submitted as https://code.google.com/p/go/source/detail?r=a9edbc33dcee 
> Hi, I wonder why Patch Set 2&3 both contained all three .syso files
> whereas the actual submitted one only contained two of them?
> what happen to race_linux_amd64.syso?

Oops. Thanks.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b