code review 6946044: test/nil.go: delete on nil maps no longer panics

test/nil.go: delete on nil maps no longer panics
Fix the build.

[minux1, 2012-12-13 18:13:42]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[minux1, 2012-12-13 18:19:47]

*** Submitted as https://code.google.com/p/go/source/detail?r=8ea9d438b64e ***

test/nil.go: delete on nil maps no longer panics
Fix the build.

R=golang-dev
CC=golang-dev
https://codereview.appspot.com/6946044

[bradfitz, 2012-12-13 18:20:04]

LGTM

On Thu, Dec 13, 2012 at 10:13 AM, <minux.ma@gmail.com> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> test/nil.go: delete on nil maps no longer panics
> Fix the build.
>
> Please review this at
https://codereview.appspot.**com/6946044/<https://codereview.appspot.com/6946...
>
> Affected files:
>   M test/nil.go
>
>
> Index: test/nil.go
> ==============================**==============================**=======
> --- a/test/nil.go
> +++ b/test/nil.go
> @@ -151,9 +151,6 @@
>         shouldPanic(func() {
>                 m[2] = 3
>         })
> -       shouldPanic(func() {
> -               delete(m, 2)
> -       })
>  }
>
>  // nil slice
>
>
>

[iant, 2012-12-13 18:56:48]

Really we should leave behind the delete line, to make sure that now it
*doesn't* panic.

[minux1, 2012-12-13 18:59:17]

On Fri, Dec 14, 2012 at 2:56 AM, <iant@golang.org> wrote:

> Really we should leave behind the delete line, to make sure that now it
> *doesn't* panic.
>
My last CL added that test to test/fixedbug directory.
http://tip.golang.org/test/fixedbugs/issue4535.go

[dave_cheney.net, 2012-12-13 18:59:20]

+1

On Fri, Dec 14, 2012 at 5:56 AM,  <iant@golang.org> wrote:
> Really we should leave behind the delete line, to make sure that now it
> *doesn't* panic.
>
> https://codereview.appspot.com/6946044/