Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(38)

Issue 6945074: code review 6945074: gotour: automatically open browser window if possible (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by minux1
Modified:
9 years, 6 months ago
Reviewers:
CC:
golang-dev, adg
Visibility:
Public.

Description

gotour: automatically open browser window if possible Fixes issue 51.

Patch Set 1 #

Patch Set 2 : diff -r 35aa8dc3dadc https://code.google.com/p/go-tour/ #

Patch Set 3 : diff -r 35aa8dc3dadc https://code.google.com/p/go-tour/ #

Patch Set 4 : diff -r 35aa8dc3dadc https://code.google.com/p/go-tour/ #

Patch Set 5 : diff -r 35aa8dc3dadc https://code.google.com/p/go-tour/ #

Patch Set 6 : diff -r 35aa8dc3dadc https://code.google.com/p/go-tour/ #

Patch Set 7 : diff -r 35aa8dc3dadc https://code.google.com/p/go-tour/ #

Patch Set 8 : diff -r 35aa8dc3dadc https://code.google.com/p/go-tour/ #

Patch Set 9 : diff -r 35aa8dc3dadc https://code.google.com/p/go-tour/ #

Total comments: 7

Patch Set 10 : diff -r 35aa8dc3dadc https://code.google.com/p/go-tour/ #

Total comments: 1

Patch Set 11 : diff -r 35aa8dc3dadc https://code.google.com/p/go-tour/ #

Total comments: 4

Patch Set 12 : diff -r 35aa8dc3dadc https://code.google.com/p/go-tour/ #

Patch Set 13 : diff -r 35aa8dc3dadc https://code.google.com/p/go-tour/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -7 lines) Patch
M gotour/local.go View 1 2 3 4 5 6 7 8 9 10 11 5 chunks +56 lines, -7 lines 0 comments Download

Messages

Total messages: 13
minux1
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go-tour/
9 years, 6 months ago (2012-12-18 14:36:15 UTC) #1
minux1
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 6 months ago (2012-12-18 16:58:48 UTC) #2
adg
https://codereview.appspot.com/6945074/diff/3004/gotour/local.go File gotour/local.go (right): https://codereview.appspot.com/6945074/diff/3004/gotour/local.go#newcode199 gotour/local.go:199: for { If someone runs gotour -http=:8080, this loop ...
9 years, 6 months ago (2012-12-18 22:22:04 UTC) #3
minux1
https://codereview.appspot.com/6945074/diff/3004/gotour/local.go File gotour/local.go (right): https://codereview.appspot.com/6945074/diff/3004/gotour/local.go#newcode199 gotour/local.go:199: for { On 2012/12/18 22:22:04, adg wrote: > If ...
9 years, 6 months ago (2012-12-18 23:07:08 UTC) #4
minux1
Hello golang-dev@googlegroups.com, adg@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 6 months ago (2012-12-18 23:07:37 UTC) #5
adg
LGTM https://codereview.appspot.com/6945074/diff/20001/gotour/local.go File gotour/local.go (right): https://codereview.appspot.com/6945074/diff/20001/gotour/local.go#newcode215 gotour/local.go:215: if tries != 0 && startBrowser(url) == nil ...
9 years, 6 months ago (2012-12-18 23:19:07 UTC) #6
adg
NOT LGTM We should add a flag -openbrowser=true so that you can run the tour ...
9 years, 6 months ago (2012-12-18 23:19:49 UTC) #7
minux1
On Wed, Dec 19, 2012 at 7:19 AM, <adg@golang.org> wrote: > We should add a ...
9 years, 6 months ago (2012-12-18 23:21:41 UTC) #8
minux1
PTAL.
9 years, 6 months ago (2012-12-18 23:24:25 UTC) #9
adg
https://codereview.appspot.com/6945074/diff/30001/gotour/local.go File gotour/local.go (right): https://codereview.appspot.com/6945074/diff/30001/gotour/local.go#newcode84 gotour/local.go:84: go waitAndStartBrowser("http://" + host + ":" + port) this ...
9 years, 6 months ago (2012-12-19 00:28:01 UTC) #10
minux1
PTAL.
9 years, 6 months ago (2012-12-19 16:20:10 UTC) #11
adg
LGTM Thanks!
9 years, 6 months ago (2012-12-19 20:53:44 UTC) #12
minux1
9 years, 6 months ago (2012-12-20 18:52:34 UTC) #13
*** Submitted as https://code.google.com/p/go-tour/source/detail?r=680e321d81fd
***

gotour: automatically open browser window if possible
Fixes issue 51.

R=golang-dev, adg
CC=golang-dev
https://codereview.appspot.com/6945074
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b