Add RRect GM

Test out rendering and clipping with some of the complex RRects allowable by CSS

[reed1, 2012-12-17 15:34:56]

suggestions:

path::addRoundRect(r, radii, dir) {
    SkRRect rr;
    rr.setRectRadii(r, radii);
    this->addRRect(rr, dir);
}

path::addRRect(rr, dir) {
   call the old code, but remove the checks (possibly use asserts), since rrect
is
   guaranteed to be valid.
}

[robertphillips, 2012-12-17 18:27:25]

PTAL

[robertphillips, 2012-12-17 18:32:00]

This CL does alter one case in the new inset/outset GM which was hitting the old
1/2 width/height clamping

[reed1, 2012-12-17 18:37:33]

lgtm w/ questions about comments (and assert code compiling)

https://codereview.appspot.com/6945063/diff/4001/include/core/SkPath.h
File include/core/SkPath.h (right):

https://codereview.appspot.com/6945063/diff/4001/include/core/SkPath.h#newcod...
include/core/SkPath.h:654: *              kUnknown_Direction.
"error handling"?

"constraint handling"  ?

https://codereview.appspot.com/6945063/diff/4001/src/core/SkPath.cpp
File src/core/SkPath.cpp (right):

https://codereview.appspot.com/6945063/diff/4001/src/core/SkPath.cpp#newcode1037
src/core/SkPath.cpp:1037: SkPath::Direction dir, bool forceMoveTo) {
// This assert is not sufficient, since really we want to know that the pair of
radii (e.g. left and right, or top and bottom) sum to <= dimension, but we don't
have that data here, so we just have this conservative assert.

https://codereview.appspot.com/6945063/diff/4001/src/core/SkPath.cpp#newcode1038
src/core/SkPath.cpp:1038: SkASSERT(0 <= rx && rx <= rect.width);
width()
height()

[robertphillips, 2012-12-17 18:46:01]

https://codereview.appspot.com/6945063/diff/4001/include/core/SkPath.h
File include/core/SkPath.h (right):

https://codereview.appspot.com/6945063/diff/4001/include/core/SkPath.h#newcod...
include/core/SkPath.h:654: *              kUnknown_Direction.
On 2012/12/17 18:37:33, reed1 wrote:
> "error handling"?
> 
> "constraint handling"  ?

Done.

https://codereview.appspot.com/6945063/diff/4001/src/core/SkPath.cpp
File src/core/SkPath.cpp (right):

https://codereview.appspot.com/6945063/diff/4001/src/core/SkPath.cpp#newcode1037
src/core/SkPath.cpp:1037: SkPath::Direction dir, bool forceMoveTo) {
On 2012/12/17 18:37:33, reed1 wrote:
> // This assert is not sufficient, since really we want to know that the pair
of
> radii (e.g. left and right, or top and bottom) sum to <= dimension, but we
don't
> have that data here, so we just have this conservative assert.

Done.

https://codereview.appspot.com/6945063/diff/4001/src/core/SkPath.cpp#newcode1038
src/core/SkPath.cpp:1038: SkASSERT(0 <= rx && rx <= rect.width);
On 2012/12/17 18:37:33, reed1 wrote:
> width()
> height()

Done.

[reed1, 2012-12-17 18:53:05]

lgtm

(I am running a local version against drt)

[robertphillips, 2012-12-17 21:48:39]

committed as r6866