Issue 6944058: state: machines now have Jobs not Workers
Descriptionstate: machines now have Jobs not Workers
Approach as agreed with niemeyer on IRC. Main point is to avoid encoding
assumptions about the workers in state: state knows what jobs an agent has
to do, and jujud knows what tasks to run to accomplish those jobs. Type is
int also at niemeyer's request; this is to allow us to refine job names in
future without disturbing running installations (assuming the responsibilities
do change in a sane way, at least).
Since I was making this change, I observed that it was trivial to fix one of
the machine-zero warts: we now mark the bootstrap machine agent off-limits
to units merely by omitting JobHostUnits. Local assignment still uses
explicit machine 0, and I'm not sure that's entirely sensible, but I think
the local assignment code is kinda speculative anyway so it seems foolish to
distract myself with it.
The bulk of this change is just s/MachinerWorker/JobHostUnits/; the more
interesting bits are in cmd/jujud/machine.go and state/assign_test.go
(and ofc state/machine.go).
https://code.launchpad.net/~fwereade/juju-core/machine-agent-jobs/+merge/140202
Requires: https://code.launchpad.net/~fwereade/juju-core/machine-agent-deployer/+merge/140174
(do not edit description out of merge proposal)
Patch Set 1 #
Total comments: 11
Patch Set 2 : state: machines now have Jobs not Workers #Patch Set 3 : state: machines now have Jobs not Workers #
MessagesTotal messages: 6
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
