code review 6944047: go.crypto/ssh: Miscellaneous changes up for discussion.

go.crypto/ssh: Miscellaneous changes up for discussion.
Export key and certificate algorithm names.
Switch from string literals over to using the constants for any key/cert algorithm references.
Make URL references visible in the godoc web display.
Standardize url reference names with surrounding [].

[jmpittman, 2012-12-13 23:19:02]

Hello dave@cheney.net, agl@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.crypto

[agl1, 2012-12-13 23:25:28]

LGTM save for the query about exporting all the key and cert type names.

https://codereview.appspot.com/6944047/diff/4001/ssh/certs.go
File ssh/certs.go (right):

https://codereview.appspot.com/6944047/diff/4001/ssh/certs.go#newcode16
ssh/certs.go:16: CertAlgoRSAv01      = "ssh-rsa-cert-v01@openssh.com"
Why export? (I assume you have a use in mind.)

[dave_cheney.net, 2012-12-13 23:27:30]

> ssh/certs.go:16: CertAlgoRSAv01      = "ssh-rsa-cert-v01@openssh.com"
> Why export? (I assume you have a use in mind.)

That was my suggestion, to avoid having to have large descriptive
comments on which algos were supported. I hoped that godoc could do
that for us.

[agl1, 2012-12-13 23:29:31]

On Thu, Dec 13, 2012 at 6:27 PM, Dave Cheney <dave@cheney.net> wrote:
> That was my suggestion, to avoid having to have large descriptive
> comments on which algos were supported. I hoped that godoc could do
> that for us.

Do we actually support all of the things that we export?


Cheers

AGL

[agl1, 2012-12-13 23:29:46]

On Thu, Dec 13, 2012 at 6:29 PM, Adam Langley <agl@golang.org> wrote:
> Do we actually support all of the things that we export?

(If so, LGTM.)

[jmpittman, 2012-12-13 23:34:26]

https://codereview.appspot.com/6944047/diff/4001/ssh/certs.go
File ssh/certs.go (right):

https://codereview.appspot.com/6944047/diff/4001/ssh/certs.go#newcode16
ssh/certs.go:16: CertAlgoRSAv01      = "ssh-rsa-cert-v01@openssh.com"
On 2012/12/13 23:25:29, agl1 wrote:
> Why export? (I assume you have a use in mind.)

I have no current use case in mind.  It was just a suggestion by dfc in the last
cl (6873060).  Since these are constants, I cannot think of a problem it would
cause, but it would give more public visibility in godoc about what is
supported.  If you think they should remain unexported, I will reverse this part
of the CL.

And as of now, yes, I do believe we support all of the things I am exporting
with this CL.  Previously, we had unexported ecdsa references, but did not
support them.

[jmp, 2012-12-14 13:30:39]

Anything else?  Or can someone submit?

[agl1, 2012-12-14 15:11:44]

*** Submitted as
https://code.google.com/p/go/source/detail?r=97169dc936c2&repo=crypto ***

go.crypto/ssh: Miscellaneous changes up for discussion.
Export key and certificate algorithm names.
Switch from string literals over to using the constants for any key/cert
algorithm references.
Make URL references visible in the godoc web display.
Standardize url reference names with surrounding [].

R=dave, agl, jonathan.mark.pittman
CC=golang-dev
https://codereview.appspot.com/6944047

Committer: Adam Langley <agl@golang.org>