Issue 6944046: move subscriptions from 1.13 -> 1.14, remove common.collect dependency, Google copyright

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6944046: move subscriptions from 1.13 -> 1.14, remove common.collect dependency, Google copyright (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by yanivi

Modified:
11 years, 4 months ago

Reviewers:
ngmiceli

CC:
rmistry

Base URL:
https://google-api-java-client.googlecode.com/hg/

Visibility:
Public.

More Reviews

Description

move subscriptions from 1.13 -> 1.14 JsonCParser: remove common.collect dependency update default file comment to include Google copyright

Patch Set 1 #

Patch Set 2 : JsonCParser: remove common.collect dependency #

Patch Set 3 : update default file comment to include Google copyright #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -36 lines)			Patch
M	google-api-client-android/.settings/org.eclipse.jdt.ui.prefs	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	google-api-client-appengine/.settings/org.eclipse.jdt.ui.prefs	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/subscriptions/AppEngineSubscriptionStore.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/subscriptions/AppEngineWebHookDeliveryMethod.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/subscriptions/CachedAppEngineSubscriptionStore.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/subscriptions/package-info.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	google-api-client-java6/.settings/org.eclipse.jdt.ui.prefs	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	google-api-client-servlet/.settings/org.eclipse.jdt.ui.prefs	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	google-api-client-servlet/src/main/java/com/google/api/client/googleapis/extensions/servlet/subscriptions/AbstractWebHookServlet.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	google-api-client-servlet/src/main/java/com/google/api/client/googleapis/extensions/servlet/subscriptions/JdoSubscriptionStore.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	google-api-client-servlet/src/main/java/com/google/api/client/googleapis/extensions/servlet/subscriptions/WebHookDeliveryMethod.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	google-api-client-servlet/src/main/java/com/google/api/client/googleapis/extensions/servlet/subscriptions/package-info.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	google-api-client/.settings/org.eclipse.jdt.ui.prefs	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	google-api-client/src/main/java/com/google/api/client/googleapis/json/JsonCParser.java	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	google-api-client/src/main/java/com/google/api/client/googleapis/services/AbstractGoogleClientRequest.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	google-api-client/src/main/java/com/google/api/client/googleapis/services/json/AbstractGoogleJsonClientRequest.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/EventTypes.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/MemorySubscriptionStore.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/Notification.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/NotificationCallback.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/NotificationHeaders.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/SubscribeRequest.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/SubscribeResponse.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/Subscription.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/SubscriptionHeaders.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/SubscriptionStore.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/TypedNotification.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/TypedNotificationCallback.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/UnparsedNotification.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/json/JsonNotificationCallback.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/json/JsonSubscribeRequest.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/json/package-info.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/package-info.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	google-api-client/src/main/java/com/google/api/client/googleapis/testing/subscriptions/MockNotificationCallback.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	google-api-client/src/main/java/com/google/api/client/googleapis/testing/subscriptions/package-info.java	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages