Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(583)

Issue 6943063: code review 6943063: syscall: document that documentation is platform specific (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 11 months ago by m4dh4tt3r
Modified:
8 years, 11 months ago
Reviewers:
CC:
golang-dev, minux1, rsc
Visibility:
Public.

Description

syscall: document that documentation is platform specific Fixes issue 4051

Patch Set 1 #

Patch Set 2 : diff -r 7e135713451d https://code.google.com/p/go #

Patch Set 3 : diff -r 7e135713451d https://code.google.com/p/go #

Total comments: 1

Patch Set 4 : diff -r 7e135713451d https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M src/pkg/syscall/syscall.go View 1 2 3 1 chunk +9 lines, -4 lines 0 comments Download

Messages

Total messages: 6
m4dh4tt3r
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
8 years, 11 months ago (2012-12-15 17:50:01 UTC) #1
minux1
https://codereview.appspot.com/6943063/diff/5001/src/pkg/syscall/syscall.go File src/pkg/syscall/syscall.go (right): https://codereview.appspot.com/6943063/diff/5001/src/pkg/syscall/syscall.go#newcode7 src/pkg/syscall/syscall.go:7: // godoc will only display the syscall documentation for ...
8 years, 11 months ago (2012-12-15 18:02:46 UTC) #2
m4dh4tt3r
PTAL On 2012/12/15 18:02:46, minux wrote: > https://codereview.appspot.com/6943063/diff/5001/src/pkg/syscall/syscall.go > File src/pkg/syscall/syscall.go (right): > > https://codereview.appspot.com/6943063/diff/5001/src/pkg/syscall/syscall.go#newcode7 ...
8 years, 11 months ago (2012-12-16 01:24:04 UTC) #3
minux1
LGTM I will wait a day or two before submitting.
8 years, 11 months ago (2012-12-16 01:35:01 UTC) #4
rsc
LGTM Submit whenever you like.
8 years, 11 months ago (2012-12-16 23:13:38 UTC) #5
minux1
8 years, 11 months ago (2012-12-17 14:50:17 UTC) #6
*** Submitted as https://code.google.com/p/go/source/detail?r=0eb63dc25fd6 ***

syscall: document that documentation is platform specific

Fixes issue 4051

R=golang-dev, minux.ma, rsc
CC=golang-dev
https://codereview.appspot.com/6943063

Committer: Shenghou Ma <minux.ma@gmail.com>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b