Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(49)

Issue 6942045: Restored notifications tests.

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by frankban
Modified:
11 years, 4 months ago
Reviewers:
mp+139677
Visibility:
Public.

Description

Restored notifications tests. This branch restores the tests previously skipped (as a consequence of the topology refactor) in ``test_application_notifications``. Simplified the way the number of notifications is tested: now, rather than checking a value in the DOM, we check how many model instances are present in the notifications model list. Also added a test for the notifications view, that was no longer exercised due to the change described above. https://code.launchpad.net/~frankban/juju-gui/fix-notification-tests/+merge/139677 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Restored notifications tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -159 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M test/test_application_notifications.js View 9 chunks +74 lines, -159 lines 0 comments Download

Messages

Total messages: 5
frankban
Please take a look.
11 years, 4 months ago (2012-12-13 11:58:04 UTC) #1
gary.poster
Land as is. Really nice, Francesco. Thank you. Gary
11 years, 4 months ago (2012-12-13 13:29:13 UTC) #2
benjamin.saller
As a fly by review, this branch made me happier than it should have, Thanks.
11 years, 4 months ago (2012-12-13 13:58:41 UTC) #3
frankban
Hi Gary and Ben, thanks for the reviews.
11 years, 4 months ago (2012-12-13 14:44:41 UTC) #4
frankban
11 years, 4 months ago (2012-12-13 14:53:51 UTC) #5
*** Submitted:

Restored notifications tests.

This branch restores the tests previously skipped
(as a consequence of the topology refactor) in
``test_application_notifications``.

Simplified the way the number of notifications is 
tested: now, rather than checking a value in the DOM, 
we check how many model instances are present in
the notifications model list.

Also added a test for the notifications view, that was
no longer exercised due to the change described above.

R=gary.poster, benjamin.saller
CC=
https://codereview.appspot.com/6942045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b