Fix GUI breakage on browser resizing.

Fix GUI breakage on browser resizing.

Fixed how yui events are handled by the component framework.
Also added two tests:
- ensure that the module synthetic events binding works;
- ensure that the custom events 'beforePageSizeRecalculation' 
  and 'afterPageSizeRecalculation' are correctly fired by 
  the environment view when the browser is resized.

QA: resize the browser, open the charm panel, resize the 
    browser again, close the charm panel, resize again, 
    re-open the panel...

https://code.launchpad.net/~frankban/juju-gui/bug-1090046-resize/+merge/139959

(do not edit description out of merge proposal)

[frankban, 2012-12-14 16:40:36]

Please take a look.

[benjamin.saller, 2012-12-14 17:07:13]

Thanks, 

This is a nice catch, a good fix and glad to see the additional tests.

+1 LGTM

https://codereview.appspot.com/6941053/diff/1/app/assets/javascripts/d3-compo...
File app/assets/javascripts/d3-components.js (right):

https://codereview.appspot.com/6941053/diff/1/app/assets/javascripts/d3-compo...
app/assets/javascripts/d3-components.js:238: var callback =
Y.bind(handler.callback, handler.context);
This is a nice fix, thank you.

[gary.poster, 2012-12-14 17:14:30]

Land as is.

Thanks, Francesco!  Great to have the user-facing fix and the general event
handling fix, and the branch has nice tests.

Gary

[frankban, 2012-12-14 17:20:20]

*** Submitted:

Fix GUI breakage on browser resizing.

Fixed how yui events are handled by the component framework.
Also added two tests:
- ensure that the module synthetic events binding works;
- ensure that the custom events 'beforePageSizeRecalculation' 
  and 'afterPageSizeRecalculation' are correctly fired by 
  the environment view when the browser is resized.

QA: resize the browser, open the charm panel, resize the 
    browser again, close the charm panel, resize again, 
    re-open the panel...

R=benjamin.saller, gary.poster
CC=
https://codereview.appspot.com/6941053