Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(848)

Issue 6941045: code review 6941045: test: move map delete test to nil.go (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by iant
Modified:
11 years, 3 months ago
Reviewers:
CC:
golang-dev, minux1, rsc
Visibility:
Public.

Description

test: move map delete test to nil.go No need for a separate test for this.

Patch Set 1 #

Total comments: 2

Patch Set 2 : diff -r 8ea9d438b64e https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 3 : diff -r 8ea9d438b64e https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 8ea9d438b64e https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 8ea9d438b64e https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r 43afb4e714ad https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -12 lines) Patch
R test/fixedbugs/issue4535.go View 1 chunk +0 lines, -12 lines 0 comments Download
M test/nil.go View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10
iant
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 3 months ago (2012-12-13 19:03:28 UTC) #1
minux1
https://codereview.appspot.com/6941045/diff/1/test/nil.go File test/nil.go (right): https://codereview.appspot.com/6941045/diff/1/test/nil.go#newcode155 test/nil.go:155: delete(m, 2) consider move these two lines above the ...
11 years, 3 months ago (2012-12-13 19:05:35 UTC) #2
iant
https://codereview.appspot.com/6941045/diff/1/test/nil.go File test/nil.go (right): https://codereview.appspot.com/6941045/diff/1/test/nil.go#newcode155 test/nil.go:155: delete(m, 2) On 2012/12/13 19:05:35, minux wrote: > consider ...
11 years, 3 months ago (2012-12-13 19:53:42 UTC) #3
rsc
LGTM
11 years, 3 months ago (2012-12-13 19:58:35 UTC) #4
minux1
https://codereview.appspot.com/6941045/diff/6001/test/nil.go File test/nil.go (right): https://codereview.appspot.com/6941045/diff/6001/test/nil.go#newcode155 test/nil.go:155: delete(m, 2) seems not changed? I expect it to ...
11 years, 3 months ago (2012-12-13 19:58:59 UTC) #5
iant
On 2012/12/13 19:58:59, minux wrote: > https://codereview.appspot.com/6941045/diff/6001/test/nil.go > File test/nil.go (right): > > https://codereview.appspot.com/6941045/diff/6001/test/nil.go#newcode155 > ...
11 years, 3 months ago (2012-12-13 20:02:39 UTC) #6
iant
OK, I think I've got it now.
11 years, 3 months ago (2012-12-13 20:05:45 UTC) #7
minux1
LGTM. sorry for not getting it right in the first CL.
11 years, 3 months ago (2012-12-13 20:06:38 UTC) #8
iant
On 2012/12/13 20:06:38, minux wrote: > LGTM. > sorry for not getting it right in ...
11 years, 3 months ago (2012-12-13 20:11:14 UTC) #9
iant
11 years, 3 months ago (2012-12-13 20:11:28 UTC) #10
*** Submitted as https://code.google.com/p/go/source/detail?r=98187cf442ac ***

test: move map delete test to nil.go

No need for a separate test for this.

R=golang-dev, minux.ma, rsc
CC=golang-dev
https://codereview.appspot.com/6941045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b