Issue 6940082: code review 6940082: cmd/go: pass gccgoflags at the end of gccgo command lin...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6940082: code review 6940082: cmd/go: pass gccgoflags at the end of gccgo command lin... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 7 months ago by minux1

Modified:
12 years, 7 months ago

Reviewers:

CC:
iant, golang-dev

Visibility:
Public.

Description

cmd/go: pass gccgoflags at the end of gccgo command line, warn if user passes the wrong toolchain options

Patch Set 1 #

Patch Set 2 : diff -r c082c3be7168 https://code.google.com/p/go/ #

Patch Set 3 : diff -r c082c3be7168 https://code.google.com/p/go/ #

Patch Set 4 : diff -r c082c3be7168 https://code.google.com/p/go/ #

Created: 12 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -1 line)			Patch
	M	src/cmd/go/build.go	View	1	2 chunks	+16 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

minux1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

12 years, 7 months ago (2012-12-18 17:32:19 UTC) #1

minux1

Hello iant@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

12 years, 7 months ago (2012-12-18 17:33:23 UTC) #2

minux1

12 years, 7 months ago (2012-12-18 17:48:22 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=940cccc0f560 ***

cmd/go: pass gccgoflags at the end of gccgo command line, warn if user passes
the wrong toolchain options

R=iant
CC=golang-dev
https://codereview.appspot.com/6940082

Expand All Messages | Collapse All Messages