code review 6939064: runtime: use "mp" and "gp" instead of "m" and "g" for l...

runtime: use "mp" and "gp" instead of "m" and "g" for local variable name to avoid confusion with the global "m" and "g".

[diogin, 2012-12-17 03:32:33]

Hello golang-dev@googlegroups.com (cc: bradfitz@golang.org,
golang-dev@googlegroups.com, rsc@golang.org),

I'd like you to review this change to
https://code.google.com/p/go

[diogin, 2012-12-17 03:43:52]

On 2012/12/17 03:32:33, diogin wrote:
> Hello mailto:golang-dev@googlegroups.com (cc: mailto:bradfitz@golang.org,
> mailto:golang-dev@googlegroups.com, mailto:rsc@golang.org),
> 
> I'd like you to review this change to
> https://code.google.com/p/go

For "m" and "g" in the following structs:

runtime/proc.c:

struct CgoThreadStart
{
	M *m;
	G *g;
	void (*fn)(void);
};

runtime/cgo/libcgo.h:

struct ThreadStart
{
	uintptr m;
	G *g;
	void (*fn)(void);
};

I think it is not the same with this CL, as they are members, not "local
variable name", just like the "g" in:

runtime/chan.c:


struct	SudoG
{
	G*	g;		// g and selgen constitute
	uint32	selgen;		// a weak pointer to g
	SudoG*	link;
	int64	releasetime;
	byte*	elem;		// data element
};

[minux1, 2012-12-17 15:46:19]

https://codereview.appspot.com/6939064/diff/4001/src/pkg/runtime/cgo/gcc_arm.S
File src/pkg/runtime/cgo/gcc_arm.S (right):

https://codereview.appspot.com/6939064/diff/4001/src/pkg/runtime/cgo/gcc_arm....
src/pkg/runtime/cgo/gcc_arm.S:15: * void crosscall_arm2(void (*fn)(void), void
*gp, void *mp)
g and m here are correct, as they are the real g and m used
to run the fn.

https://codereview.appspot.com/6939064/diff/4001/src/pkg/runtime/cgo/gcc_darw...
File src/pkg/runtime/cgo/gcc_darwin_386.c (right):

https://codereview.appspot.com/6939064/diff/4001/src/pkg/runtime/cgo/gcc_darw...
src/pkg/runtime/cgo/gcc_darwin_386.c:105: xinitcgo(G *gp)
in general, i think we can leave g and m in
gcc compiled cgo source files alone, as
there aren't global m, g here so no confusions
possible.

https://codereview.appspot.com/6939064/diff/4001/src/pkg/runtime/cgocall.c
File src/pkg/runtime/cgocall.c (right):

https://codereview.appspot.com/6939064/diff/4001/src/pkg/runtime/cgocall.c#ne...
src/pkg/runtime/cgocall.c:45: // (in cgo/$GOOS.S, a gcc-compiled assembly file)
is a two-argument
while you're at here, could you please fix this path?

cgo/gcc_$GOARCH.S

[rsc, 2012-12-17 16:12:26]

Please revert the changes in runtime/cgo. That's a different package.
Otherwise, looks fine to me. Will leave for Minux to submit.

[diogin, 2012-12-18 02:22:49]

Hello golang-dev@googlegroups.com, minux.ma@gmail.com, rsc@golang.org (cc:
bradfitz@golang.org, golang-dev@googlegroups.com),

Please take another look.

[minux1, 2012-12-18 16:29:16]

LGTM. Will submit with the following changes.

https://codereview.appspot.com/6939064/diff/4003/src/pkg/runtime/cgocall.c
File src/pkg/runtime/cgocall.c (right):

https://codereview.appspot.com/6939064/diff/4003/src/pkg/runtime/cgocall.c#ne...
src/pkg/runtime/cgocall.c:45: // (in cgo/$GOOS.S, a gcc-compiled assembly file)
is a two-argument
while you're at here, could you please fix this path?

cgo/gcc_$GOARCH.S

https://codereview.appspot.com/6939064/diff/4003/src/pkg/runtime/thread_darwin.c
File src/pkg/runtime/thread_darwin.c (right):

https://codereview.appspot.com/6939064/diff/4003/src/pkg/runtime/thread_darwi...
src/pkg/runtime/thread_darwin.c:97: runtime·printf("newosproc stk=%p mp=%p gp=%p
fn=%p id=%d/%d ostk=%p\n",
i'd prefer we don't change the format string, since no confusion possible.

https://codereview.appspot.com/6939064/diff/4003/src/pkg/runtime/thread_freeb...
File src/pkg/runtime/thread_freebsd.c (right):

https://codereview.appspot.com/6939064/diff/4003/src/pkg/runtime/thread_freeb...
src/pkg/runtime/thread_freebsd.c:86: USED(gp);	// thr_start assumes gp == m->g0
s/m->g0/mp->g0/

https://codereview.appspot.com/6939064/diff/4003/src/pkg/runtime/thread_freeb...
src/pkg/runtime/thread_freebsd.c:89: runtime·printf("newosproc stk=%p mp=%p
gp=%p fn=%p id=%d/%d ostk=%p\n",
ditto.

https://codereview.appspot.com/6939064/diff/4003/src/pkg/runtime/thread_linux.c
File src/pkg/runtime/thread_linux.c (right):

https://codereview.appspot.com/6939064/diff/4003/src/pkg/runtime/thread_linux...
src/pkg/runtime/thread_linux.c:145: runtime·printf("newosproc stk=%p mp=%p gp=%p
fn=%p clone=%p id=%d/%d ostk=%p\n",
ditto.

https://codereview.appspot.com/6939064/diff/4003/src/pkg/runtime/thread_netbsd.c
File src/pkg/runtime/thread_netbsd.c (right):

https://codereview.appspot.com/6939064/diff/4003/src/pkg/runtime/thread_netbs...
src/pkg/runtime/thread_netbsd.c:159: "newosproc stk=%p mp=%p gp=%p fn=%p
id=%d/%d ostk=%p\n",
ditto.

https://codereview.appspot.com/6939064/diff/4003/src/pkg/runtime/thread_openb...
File src/pkg/runtime/thread_openbsd.c (right):

https://codereview.appspot.com/6939064/diff/4003/src/pkg/runtime/thread_openb...
src/pkg/runtime/thread_openbsd.c:134: "newosproc stk=%p mp=%p gp=%p fn=%p
id=%d/%d ostk=%p\n",
ditto.

https://codereview.appspot.com/6939064/diff/4003/src/pkg/runtime/thread_plan9.c
File src/pkg/runtime/thread_plan9.c (right):

https://codereview.appspot.com/6939064/diff/4003/src/pkg/runtime/thread_plan9...
src/pkg/runtime/thread_plan9.c:261: runtime·printf("newosproc stk=%p mp=%p gp=%p
fn=%p rfork=%p id=%d/%d ostk=%p\n",
ditto.

https://codereview.appspot.com/6939064/diff/4003/src/pkg/runtime/thread_windo...
File src/pkg/runtime/thread_windows.c (right):

https://codereview.appspot.com/6939064/diff/4003/src/pkg/runtime/thread_windo...
src/pkg/runtime/thread_windows.c:194: USED(gp);	// assuming gp = m->g0
s/m->g0/mp->g0/

[minux1, 2012-12-18 16:30:49]

*** Submitted as https://code.google.com/p/go/source/detail?r=c082c3be7168 ***

runtime: use "mp" and "gp" instead of "m" and "g" for local variable name to
avoid confusion with the global "m" and "g".

R=golang-dev, minux.ma, rsc
CC=bradfitz, golang-dev
https://codereview.appspot.com/6939064

Committer: Shenghou Ma <minux.ma@gmail.com>