Issue 6938076: code review 6938076: cmd/5l, cmd/6l, cmd/8l: fix function symbol from gcc co...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6938076: code review 6938076: cmd/5l, cmd/6l, cmd/8l: fix function symbol from gcc co... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 7 months ago by minux1

Modified:
12 years, 7 months ago

Reviewers:

CC:
jsing, rsc, golang-dev

Visibility:
Public.

Description

cmd/5l, cmd/6l, cmd/8l: fix function symbol generation from gcc compiled source code For CL 6853059.

Patch Set 1 #

Patch Set 2 : diff -r 6625c3cb4d0e https://code.google.com/p/go/ #

Patch Set 3 : diff -r 6625c3cb4d0e https://code.google.com/p/go/ #

Patch Set 4 : diff -r 6625c3cb4d0e https://code.google.com/p/go/ #

Created: 12 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
M	src/cmd/5l/asm.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/6l/asm.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/8l/asm.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

minux1

Hello jsing@google.com, rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

12 years, 7 months ago (2012-12-18 15:04:46 UTC) #1

minux1

12 years, 7 months ago (2012-12-18 15:17:54 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=617db9efbdf1 ***

cmd/5l, cmd/6l, cmd/8l: fix function symbol generation from gcc compiled source
code
For CL 6853059.

R=jsing, rsc
CC=golang-dev
https://codereview.appspot.com/6938076

Expand All Messages | Collapse All Messages