Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4428)

Issue 6938074: Android path renderer now compiling with Skia (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by JimVV
Modified:
11 years, 4 months ago
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Android path renderer now compiling with Skia: - Changed Matrix to SkMatrix - Changed vec2 to SkVector - Changed Vector<> to SkTArray<,> - Changed ALOGD to SkDebugf - Changed ALOGV to use SkDebugf with compile option - Changed ATRACE_CALL to SK_TRACE_EVENT0 - Changed static method names to be capitalized - Changed return values to be passed by pointer not ref

Patch Set 1 #

Total comments: 1

Patch Set 2 : Updated to make a little more coding standards friendly #

Unified diffs Side-by-side diffs Delta from patch set Stats (+225 lines, -204 lines) Patch
M AndroidPathRenderer/AndroidPathRenderer.h View 1 2 chunks +12 lines, -13 lines 0 comments Download
M AndroidPathRenderer/AndroidPathRenderer.cpp View 1 21 chunks +213 lines, -191 lines 0 comments Download

Messages

Total messages: 8
JimVV
This is only a beginning, but seems like a reasonably stable point to commit before ...
11 years, 4 months ago (2012-12-17 19:59:38 UTC) #1
bsalomon
On 2012/12/17 19:59:38, JimVV wrote: > This is only a beginning, but seems like a ...
11 years, 4 months ago (2012-12-17 20:02:31 UTC) #2
reed1
drive-by nits https://codereview.appspot.com/6938074/diff/1/experimental/AndroidPathRenderer/AndroidPathRenderer.h File experimental/AndroidPathRenderer/AndroidPathRenderer.h (right): https://codereview.appspot.com/6938074/diff/1/experimental/AndroidPathRenderer/AndroidPathRenderer.h#newcode63 experimental/AndroidPathRenderer/AndroidPathRenderer.h:63: private: skia conventions: - Capitalize Static Methods ...
11 years, 4 months ago (2012-12-17 20:04:27 UTC) #3
robertphillips
LGTM but we should resolve the "Android conventions vs. Skia conventions" issue sooner rather than ...
11 years, 4 months ago (2012-12-17 20:11:10 UTC) #4
JimVV
Nits picked
11 years, 4 months ago (2012-12-17 20:56:35 UTC) #5
bsalomon
On 2012/12/17 20:56:35, JimVV wrote: > Nits picked I can come up with more style ...
11 years, 4 months ago (2012-12-17 21:10:46 UTC) #6
JimVV
I mainly did the style changes to get into practice. I can roll them back ...
11 years, 4 months ago (2012-12-17 21:42:36 UTC) #7
JimVV
11 years, 4 months ago (2012-12-18 14:15:44 UTC) #8
Message was sent while issue was closed.
Committed as revision 6874.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b