Issue 6938072: jujud: machine agent removes dead units

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6938072: jujud: machine agent removes dead units

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by fwereade

Modified:
12 years, 4 months ago

Reviewers:
dimitern, mp+140174, rog

Visibility:
Public.

Description

jujud: machine agent removes dead units This was accomplished by using a Deployer in place of a Machiner, thereby rendering redundant and enabling the removal of: * the container package * the worker/machiner package * the state.MachinePrincipalUnitsWatcher type In the name of clarity and convenience, the following methods were added: * (*state.State) Addrs() []string * (*state.State) CACert() []byte * (*state.UnitsWatcher) EntityName() string ...allowing for neater Manager and Deployer creation. https://code.launchpad.net/~fwereade/juju-core/machine-agent-deployer/+merge/140174 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : jujud: machine agent removes dead units #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+80 lines, -930 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/jujud/machine.go	View	2 chunks	+8 lines, -2 lines	0 comments	Download
D	container/container.go	View	1 chunk	+0 lines, -114 lines	0 comments	Download
D	container/container_test.go	View	1 chunk	+0 lines, -111 lines	0 comments	Download
M	state/machine_test.go	View	2 chunks	+3 lines, -259 lines	0 comments	Download
M	state/open.go	View	4 chunks	+20 lines, -9 lines	0 comments	Download
M	state/state.go	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	state/state_test.go	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	state/watcher.go	View	6 chunks	+32 lines, -166 lines	0 comments	Download
M	worker/deployer/deployer.go	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	worker/deployer/deployer_test.go	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	worker/deployer/simple.go	View	1 chunk	+2 lines, -2 lines	0 comments	Download
D	worker/machiner/export_test.go	View	1 chunk	+0 lines, -10 lines	0 comments	Download
D	worker/machiner/machiner.go	View	1 chunk	+0 lines, -95 lines	0 comments	Download
D	worker/machiner/machiner_test.go	View	1 chunk	+0 lines, -156 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dimitern

On 2012/12/17 11:25:41, fwereade wrote: > Please take a look. LGTM, nice!

12 years, 4 months ago (2012-12-17 12:21:29 UTC) #2

rog

On 2012/12/17 12:21:29, dimitern wrote: > On 2012/12/17 11:25:41, fwereade wrote: > > Please take ...

12 years, 4 months ago (2012-12-17 13:52:10 UTC) #3

fwereade

12 years, 4 months ago (2012-12-17 14:41:41 UTC) #4

*** Submitted:

jujud: machine agent removes dead units

This was accomplished by using a Deployer in place of a Machiner, thereby
rendering redundant and enabling the removal of:

  * the container package
  * the worker/machiner package
  * the state.MachinePrincipalUnitsWatcher type

In the name of clarity and convenience, the following methods were added:

  * (*state.State) Addrs() []string
  * (*state.State) CACert() []byte
  * (*state.UnitsWatcher) EntityName() string

...allowing for neater Manager and Deployer creation.

R=dimitern, rog
CC=
https://codereview.appspot.com/6938072

Expand All Messages | Collapse All Messages