code review 6938068: encoding/xml: Marshal ",any" fields

encoding/xml: Marshal ",any" fields

Fixes issue 3559.

This makes Marshal handle fields marked ",any" instead of ignoring
them. That makes Marshal more symmetrical with Unmarshal, which seems
to have been a design goal.

Note some test cases were changed, because this patch changes
marshalling behavior. I think the previous behavior was buggy, but
there's still a backward-compatibility question to consider.

[cjyar, 2012-12-16 04:19:56]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[rsc, 2012-12-17 15:04:03]

Please add a test with an AnyHolder and ",any,omitempty". That should behave
like in your test cases but not add the new fields.

Please add a test with a []AnyHolder and ",any". It should be able to handle
multiple unknown blocks and reproduce them during Marshal. It should also not
generate any XML if there was nothing in it, because the loop over the slice
will execute 0 times.

Gustavo, any thoughts?

[cjyar, 2012-12-18 05:15:15]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com, n13m3y3r@gmail.com),

Please take another look.

[rsc, 2012-12-22 15:00:44]

*** Submitted as https://code.google.com/p/go/source/detail?r=7ea16cd2859c ***

encoding/xml: Marshal ",any" fields

Fixes issue 3559.

This makes Marshal handle fields marked ",any" instead of ignoring
them. That makes Marshal more symmetrical with Unmarshal, which seems
to have been a design goal.

Note some test cases were changed, because this patch changes
marshalling behavior. I think the previous behavior was buggy, but
there's still a backward-compatibility question to consider.

R=rsc
CC=golang-dev, n13m3y3r
https://codereview.appspot.com/6938068

Committer: Russ Cox <rsc@golang.org>