Issue 6938066: revert revision 780

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6938066: revert revision 780 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by dave

Modified:
11 years, 4 months ago

Reviewers:
mp+140030

Visibility:
Public.

Description

revert revision 780 The cmd/jujud tests are failing with an authorisation error. As Frank is on leave til after xmas and rev 780 was only intended to increase test coverage, I propose reverting this change so we can do the 1.9.4 release. http://bazaar.launchpad.net/~gophers/juju-core/trunk/revision/780 https://code.launchpad.net/~dave-cheney/juju-core/tip/+merge/140030 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : revert revision 780 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+146 lines, -282 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	worker/firewaller/firewaller.go	View	15 chunks	+140 lines, -218 lines	0 comments	Download
M	worker/firewaller/firewaller_test.go	View	5 chunks	+4 lines, -64 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

dave_cheney.net

11 years, 4 months ago (2012-12-15 01:39:02 UTC) #2

*** Submitted:

revert revision 780

The cmd/jujud tests are failing with an authorisation error. As Frank is on
leave til after xmas and rev 780 was only intended to increase test coverage, I
propose reverting this change so we can do the 1.9.4 release.

http://bazaar.launchpad.net/~gophers/juju-core/trunk/revision/780

R=
CC=
https://codereview.appspot.com/6938066

Expand All Messages | Collapse All Messages