Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(956)

Issue 6938045: code review 6938045: encoding/json: fix type assertion in error path (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 12 months ago by dfc
Modified:
9 years, 11 months ago
Reviewers:
rsc, remyoudompheng
CC:
golang-dev
Visibility:
Public.

Description

encoding/json: fix type assertion in error path Update issue 4474. Fixes issue 4222. Not all code calls panic(error), some code calls panic(string)

Patch Set 1 #

Patch Set 2 : diff -r 3fe40a41018d https://code.google.com/p/go #

Patch Set 3 : diff -r 7e135713451d https://code.google.com/p/go #

Patch Set 4 : diff -r 7e135713451d https://code.google.com/p/go #

Patch Set 5 : diff -r 7e135713451d https://code.google.com/p/go #

Patch Set 6 : diff -r 7e135713451d https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -6 lines) Patch
M src/pkg/encoding/json/decode.go View 1 2 2 chunks +6 lines, -3 lines 0 comments Download
M src/pkg/encoding/json/decode_test.go View 1 2 3 2 chunks +17 lines, -0 lines 0 comments Download
M src/pkg/encoding/json/encode.go View 1 2 3 4 5 2 chunks +8 lines, -3 lines 0 comments Download
M src/pkg/encoding/json/encode_test.go View 1 2 3 4 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 4
dfc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
9 years, 11 months ago (2012-12-15 11:16:46 UTC) #1
remyoudompheng
I don't think you should catch panic(string), issues 4222 and 4474 are programming errors in ...
9 years, 11 months ago (2012-12-15 11:48:35 UTC) #2
rsc
I think this is too broad a fix. Let's fix the (apparently few) panics taking ...
9 years, 11 months ago (2012-12-17 00:50:57 UTC) #3
dfc
9 years, 11 months ago (2012-12-17 09:37:12 UTC) #4
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b