Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3145)

Issue 6938044: Issue 2172: Get line and column numbers right. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by dak
Modified:
11 years, 4 months ago
Reviewers:
Graham Percival
CC:
lilypond-devel_gnu.org, wbsoft_xs4all.nl
Visibility:
Public.

Description

Issue 2172: Get line and column numbers right. This uses 1-based columns on all error output, as is the standard for GNU programs. It also flags version errors as being for line 1 instead of line 0 since the latter confuses Emacs' compilation mode. The same column convention is used for point-and-click column numbers in textedit:// URIs. In contrast, the byte offsets into a line (also in those URIs) are retained 0-based. For point-and-click, this yields the correct results when using the definitions for emacs and gvim in scm/editor.scm, the editors configured to interpret the column number. It is to be expected that Lilypond-specific shells (like Frescobaldi called via Okular for point-and-click) have specialized on the previous wrong behavior and will now exhibit the kind of one-off behavior that non-LilyPond specific programs did previously when encountering the error messages. I don't see a good migration strategy for those except possibly looking for the version number of LilyPond and deciding whether to do one-off calculations depending on that.

Patch Set 1 #

Patch Set 2 : Add changelog entry #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M Documentation/changes.tely View 1 1 chunk +7 lines, -0 lines 0 comments Download
M lily/source-file.cc View 1 chunk +1 line, -1 line 0 comments Download
M scm/lily-library.scm View 1 chunk +2 lines, -2 lines 0 comments Download
M scm/output-ps.scm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
Graham Percival
could we get something in Changes.tely about this? No need to update this patch; you ...
11 years, 4 months ago (2012-12-16 01:08:31 UTC) #1
dak
On 2012/12/16 01:08:31, Graham Percival wrote: > could we get something in Changes.tely about this? ...
11 years, 4 months ago (2012-12-16 08:15:43 UTC) #2
dak
11 years, 4 months ago (2012-12-16 10:47:04 UTC) #3
Add changelog entry
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b