Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(45)

Issue 6937059: code review 6937059: net: change ListenUnixgram signature to return UnixConn... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by mikio
Modified:
9 years, 6 months ago
Reviewers:
CC:
rsc, golang-dev, dfc
Visibility:
Public.

Description

net: change ListenUnixgram signature to return UnixConn instead of UDPConn This CL breaks Go 1 API compatibility but it doesn't matter because previous ListenUnixgram doesn't work in any use cases, oops. The public API change is: -pkg net, func ListenUnixgram(string, *UnixAddr) (*UDPConn, error) +pkg net, func ListenUnixgram(string, *UnixAddr) (*UnixConn, error) Fixes issue 3875.

Patch Set 1 : diff -r 5a40587c014a https://code.google.com/p/go #

Patch Set 2 : diff -r 5a40587c014a https://code.google.com/p/go #

Patch Set 3 : diff -r 5a40587c014a https://code.google.com/p/go #

Patch Set 4 : diff -r 9e8d16052155 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -88 lines) Patch
M api/except.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M doc/go1.1.html View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M src/pkg/net/dial.go View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/net/protoconn_test.go View 3 chunks +39 lines, -4 lines 0 comments Download
M src/pkg/net/unixsock_plan9.go View 3 chunks +11 lines, -10 lines 0 comments Download
M src/pkg/net/unixsock_posix.go View 13 chunks +74 lines, -73 lines 0 comments Download

Messages

Total messages: 9
mikio
Hello rsc@golang.org, golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
9 years, 6 months ago (2012-12-15 02:53:47 UTC) #1
dfc
I think the API breakage has to be documented in $GOROOT/api/except.txt
9 years, 6 months ago (2012-12-15 03:13:51 UTC) #2
mikio
Hello rsc@golang.org, golang-dev@googlegroups.com, dave@cheney.net (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 6 months ago (2012-12-15 04:00:40 UTC) #3
mikio
On Sat, Dec 15, 2012 at 12:13 PM, <dave@cheney.net> wrote: > I think the API ...
9 years, 6 months ago (2012-12-15 04:01:43 UTC) #4
dfc
And would probably warrant a mention in the go1.1 release notes. On 15 Dec 2012 ...
9 years, 6 months ago (2012-12-15 04:24:34 UTC) #5
mikio
I'd prefer doing it later with other stuff, such as IPv6. On Sat, Dec 15, ...
9 years, 6 months ago (2012-12-15 04:27:58 UTC) #6
rsc
Please add a short note to doc/go1.1.html. This is small enough that we might forget ...
9 years, 6 months ago (2012-12-15 18:13:25 UTC) #7
rsc
LGTM
9 years, 6 months ago (2012-12-15 18:13:43 UTC) #8
mikio
9 years, 6 months ago (2012-12-16 02:51:58 UTC) #9
*** Submitted as https://code.google.com/p/go/source/detail?r=a70be086fe02 ***

net: change ListenUnixgram signature to return UnixConn instead of UDPConn

This CL breaks Go 1 API compatibility but it doesn't matter because
previous ListenUnixgram doesn't work in any use cases, oops.

The public API change is:
-pkg net, func ListenUnixgram(string, *UnixAddr) (*UDPConn, error)
+pkg net, func ListenUnixgram(string, *UnixAddr) (*UnixConn, error)

Fixes issue 3875.

R=rsc, golang-dev, dave
CC=golang-dev
https://codereview.appspot.com/6937059
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b