Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(545)

Issue 6937058: code review 6937058: cmd/gc: fix defaultlit of shifts used in interface context. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 9 months ago by remyoudompheng
Modified:
9 years, 9 months ago
Reviewers:
CC:
golang-dev, rsc
Visibility:
Public.

Description

cmd/gc: fix defaultlit of shifts used in interface context. Fixes issue 4545.

Patch Set 1 #

Patch Set 2 : diff -r 5a40587c014a https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 5a40587c014a https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 7e135713451d https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M src/cmd/gc/const.c View 1 1 chunk +5 lines, -0 lines 0 comments Download
A test/fixedbugs/issue4545.go View 1 2 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 3
remyoudompheng
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
9 years, 9 months ago (2012-12-14 23:27:29 UTC) #1
rsc
LGTM
9 years, 9 months ago (2012-12-15 18:10:46 UTC) #2
remyoudompheng
9 years, 9 months ago (2012-12-15 18:38:53 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=9e8d16052155 ***

cmd/gc: fix defaultlit of shifts used in interface context.

Fixes issue 4545.

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/6937058
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b