Issue 6936045: Misc. improvements to Makefile.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6936045: Misc. improvements to Makefile.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by teknico

Modified:
11 years, 4 months ago

Reviewers:
mp+139768

Visibility:
Public.

Description

Misc. improvements to Makefile. Eliminate debug/prod link duplication, avoid unnecessary rebuilds, add version info to build. https://code.launchpad.net/~teknico/juju-gui/improve-makefile/+merge/139768 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Misc. improvements to Makefile. #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+83 lines, -72 lines)			Patch
M	Makefile	View	10 chunks	+82 lines, -73 lines	0 comments	Download
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/config-prod.js	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	app/modules-prod.js	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	lib/server.js	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

gary.poster

Thank you both for being willing to take the half-done branch I had and run ...

11 years, 4 months ago (2012-12-13 19:01:18 UTC) #2

frankban

Land as is. Thanks for this clean up Nicola and Gary. https://codereview.appspot.com/6936045/diff/1/Makefile File Makefile (right): ...

11 years, 4 months ago (2012-12-14 12:11:42 UTC) #3

teknico

11 years, 4 months ago (2012-12-14 12:15:50 UTC) #4

*** Submitted:

Misc. improvements to Makefile.

Eliminate debug/prod link duplication, avoid unnecessary rebuilds, add version
info to build.

R=gary.poster, frankban
CC=
https://codereview.appspot.com/6936045

Expand All Messages | Collapse All Messages