Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(299)

Issue 69360043: code review 69360043: runtime: fix build on Plan 9 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by 0intro
Modified:
11 years, 3 months ago
Reviewers:
minux1, bradfitz
CC:
khr, minux1, bradfitz, golang-codereviews
Visibility:
Public.

Description

runtime: fix build on Plan 9 warning: src/pkg/runtime/mem_plan9.c:72 param declared and not used: n src/pkg/runtime/mem_plan9.c:73 name not declared: nbytes src/pkg/runtime/mem_plan9.c:73 bad in naddr: NAME nbytes<>+0(SB)

Patch Set 1 #

Patch Set 2 : diff -r 125e69d99b5d https://code.google.com/p/go #

Patch Set 3 : diff -r 125e69d99b5d https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/pkg/runtime/mem_plan9.c View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
0intro
Hello khr (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
11 years, 3 months ago (2014-02-27 08:18:17 UTC) #1
minux1
Trivial enough. LGTM.
11 years, 3 months ago (2014-02-27 08:20:20 UTC) #2
bradfitz
LGTM On Feb 27, 2014 12:18 AM, <0intro@gmail.com> wrote: > Reviewers: khr, > > Message: ...
11 years, 3 months ago (2014-02-27 08:20:30 UTC) #3
0intro
11 years, 3 months ago (2014-02-27 08:22:18 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=384c869af008 ***

runtime: fix build on Plan 9

warning: src/pkg/runtime/mem_plan9.c:72 param declared and not used: n
src/pkg/runtime/mem_plan9.c:73 name not declared: nbytes
src/pkg/runtime/mem_plan9.c:73 bad in naddr: NAME nbytes<>+0(SB)

LGTM=minux.ma, bradfitz
R=khr, minux.ma, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/69360043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b