Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3)

Issue 6935071: code review 6935071: go/doc: add "hdr-" prefix to headers generated from pac... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by dsymonds
Modified:
9 years, 5 months ago
Reviewers:
minux1, adg, gburd
CC:
golang-dev, bradfitz, gri
Visibility:
Public.

Description

go/doc: add "hdr-" prefix to headers generated from package overviews.

Patch Set 1 #

Patch Set 2 : diff -r e29b9036a11a https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r e29b9036a11a https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r e29b9036a11a https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/pkg/go/doc/comment.go View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 25
dsymonds
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
9 years, 6 months ago (2012-12-18 00:33:51 UTC) #1
bradfitz
To which ones? Where's the conflict? On Mon, Dec 17, 2012 at 4:33 PM, <dsymonds@golang.org> ...
9 years, 6 months ago (2012-12-18 00:55:53 UTC) #2
bradfitz
LGTM Oh, just those <h3s> in the package overview. On Mon, Dec 17, 2012 at ...
9 years, 6 months ago (2012-12-18 00:59:56 UTC) #3
gri
LGTM
9 years, 6 months ago (2012-12-18 01:10:45 UTC) #4
dsymonds
*** Submitted as https://code.google.com/p/go/source/detail?r=3684de5292bf *** go/doc: add "hdr-" prefix to headers generated from package overviews. ...
9 years, 6 months ago (2012-12-18 01:19:15 UTC) #5
adg
This has broken anyone who ever linked to a fragment. There are many in our ...
9 years, 5 months ago (2013-01-15 05:48:10 UTC) #6
dsymonds
On Tue, Jan 15, 2013 at 4:47 PM, Andrew Gerrand <adg@golang.org> wrote: > This has ...
9 years, 5 months ago (2013-01-15 05:54:57 UTC) #7
gburd
On Monday, January 14, 2013 9:47:39 PM UTC-8, Andrew Gerrand wrote: > This has broken ...
9 years, 5 months ago (2013-01-15 13:16:08 UTC) #8
minux1
On Tue, Jan 15, 2013 at 9:16 PM, Gary Burd <gary.burd@gmail.com> wrote: > On Monday, ...
9 years, 5 months ago (2013-01-15 14:03:29 UTC) #9
adg
On 16 January 2013 00:16, Gary Burd <gary.burd@gmail.com> wrote: > This change also brok links ...
9 years, 5 months ago (2013-01-15 21:14:50 UTC) #10
minux1
On Wed, Jan 16, 2013 at 5:14 AM, Andrew Gerrand <adg@golang.org> wrote: > > On ...
9 years, 5 months ago (2013-01-15 21:18:02 UTC) #11
gburd
> Links to or links from? > Can you provide an example? > From sites ...
9 years, 5 months ago (2013-01-15 21:49:55 UTC) #12
minux1
On Wed, Jan 16, 2013 at 5:49 AM, Gary Burd <gary.burd@gmail.com> wrote: > > Links ...
9 years, 5 months ago (2013-01-15 21:57:54 UTC) #13
adg
On 16 January 2013 08:57, minux <minux.ma@gmail.com> wrote: > I wonder if this should be ...
9 years, 5 months ago (2013-01-15 22:11:42 UTC) #14
dsymonds
The original motivation was a large package that had an overview section header with the ...
9 years, 5 months ago (2013-01-15 22:21:20 UTC) #15
gburd
It's difficult to find out how many links are affected. It's possible that the links ...
9 years, 5 months ago (2013-01-15 22:22:02 UTC) #16
adg
On 16 January 2013 09:22, Gary Burd <gary.burd@gmail.com> wrote: > Because two comments can include ...
9 years, 5 months ago (2013-01-15 22:26:51 UTC) #17
minux1
On Wed, Jan 16, 2013 at 6:21 AM, David Symonds <dsymonds@golang.org> wrote: > The original ...
9 years, 5 months ago (2013-01-15 22:28:28 UTC) #18
adg
On 16 January 2013 09:28, minux <minux.ma@gmail.com> wrote: > How about we do this: we ...
9 years, 5 months ago (2013-01-15 22:30:47 UTC) #19
minux1
On Wed, Jan 16, 2013 at 6:30 AM, Andrew Gerrand <adg@golang.org> wrote: > > On ...
9 years, 5 months ago (2013-01-15 22:32:51 UTC) #20
bradfitz
On Tue, Jan 15, 2013 at 2:30 PM, Andrew Gerrand <adg@golang.org> wrote: > > On ...
9 years, 5 months ago (2013-01-15 23:53:47 UTC) #21
dsymonds
On Wed, Jan 16, 2013 at 10:53 AM, Brad Fitzpatrick <bradfitz@golang.org> wrote: > I wouldn't ...
9 years, 5 months ago (2013-01-16 00:08:26 UTC) #22
adg
On 16 January 2013 11:08, David Symonds <dsymonds@golang.org> wrote: > I would be fine with ...
9 years, 5 months ago (2013-01-16 00:12:11 UTC) #23
gburd
> That is very unlikely compared to the motivating example. For one thing, we haven't ...
9 years, 5 months ago (2013-01-16 02:43:55 UTC) #24
adg
9 years, 5 months ago (2013-01-16 03:12:15 UTC) #25
Actually, it's three in that case!

It's worth noting that this change doesn't affect that issue.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b