code review 69340044: net: fix non-blocking connect handling on dragonfly

net: fix non-blocking connect handling on dragonfly

Performing multiple connect system calls on a non-blocking socket
under DragonFly BSD does not necessarily result in errors from earlier
connect calls being returned, particularly if we are connecting to
localhost. Instead, once netpoll tells us that the socket is ready,
get the SO_ERROR socket option to see if the connection succeeded
or failed.

Fixes issue 7474

[jsing, 2014-03-05 12:47:32]

Hello mikioh.mikioh@gmail.com (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[mikio, 2014-03-05 13:04:21]

LGTM

[jsing, 2014-03-05 13:07:26]

*** Submitted as https://code.google.com/p/go/source/detail?r=2c2ecbe5ae2a ***

net: fix non-blocking connect handling on dragonfly

Performing multiple connect system calls on a non-blocking socket
under DragonFly BSD does not necessarily result in errors from earlier
connect calls being returned, particularly if we are connecting to
localhost. Instead, once netpoll tells us that the socket is ready,
get the SO_ERROR socket option to see if the connection succeeded
or failed.

Fixes issue 7474

LGTM=mikioh.mikioh
R=mikioh.mikioh
CC=golang-codereviews
https://codereview.appspot.com/69340044

[gobot, 2014-03-05 13:18:57]

This CL appears to have broken the netbsd-amd64-bsiegert builder.