Issue 6933052: code review 6933052: runtime/race: fix test for GOMAXPROCS>1

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6933052: code review 6933052: runtime/race: fix test for GOMAXPROCS>1 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by albert.strasheim

Modified:
11 years, 11 months ago

Reviewers:

CC:
dvyukov, dave_cheney.net, golang-dev

Visibility:
Public.

Description

runtime/race: fix test for GOMAXPROCS>1 Fixes issue 4530.

Patch Set 1 #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	src/pkg/runtime/race/race_test.go	View		1 chunk	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

albert.strasheim

Hello dvyukov, dfc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

12 years, 3 months ago (2012-12-12 13:28:52 UTC) #1

albert.strasheim

Care to commit this? Thanks. On 2012/12/12 13:33:59, dvyukov wrote: > LGTM > Thanks!

12 years, 3 months ago (2012-12-13 04:54:40 UTC) #3

dvyukov

12 years, 3 months ago (2012-12-13 06:15:15 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=89e5cabaa09a ***

runtime/race: fix test for GOMAXPROCS>1

Fixes issue 4530.

R=dvyukov, dave
CC=golang-dev
https://codereview.appspot.com/6933052

Committer: Dmitriy Vyukov <dvyukov@google.com>

Expand All Messages | Collapse All Messages