Issue 69320043: code review 69320043: cmd/ld: DWARF opcode base to 10
|
Created:
11 years, 3 months ago by graham_king Modified:
11 years, 3 months ago CC:
golang-codereviews, rsc, josharian, iant, bradfitz Visibility:
Public. |
Descriptioncmd/ld: DWARF opcode base to 10
DWARF 2 has 9 standard opcodes, so dwarfdump expects us to use an
opcode base of at least 10. Previously we used 5.
Discussion:
https://groups.google.com/forum/#!topic/golang-dev/d-BqpPgalzc
Patch Set 1 : diff -r d50b94cf70db https://code.google.com/p/go/ #
Total comments: 1
MessagesTotal messages: 12
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
Sign in to reply to this message.
R=rsc@golang.org (assigned by r@golang.org)
Sign in to reply to this message.
LGTM but will wait for rsc Thanks, Graham! Will you sign the CLA linked to from the bottom of http://golang.org/doc/contribute.html? https://codereview.appspot.com/69320043/diff/20001/src/cmd/ld/dwarf.c File src/cmd/ld/dwarf.c (right): https://codereview.appspot.com/69320043/diff/20001/src/cmd/ld/dwarf.c#newcode... src/cmd/ld/dwarf.c:1415: OPCODE_BASE = 10 A comment here would be nice, something to the effect of "DWARF 2 has 9 standard opcodes". Note that DWARF 3 has 12 standard opcodes, so the DWARF version matters.
Sign in to reply to this message.
On Thu, Feb 27, 2014 at 9:18 AM, Graham King <graham@gkgk.org> wrote: > I signed the CLA in May 2012 as graham@gkgk.org, for this issue: http://code.google.com/p/go/issues/detail?id=3339 > > I use graham@gkgk.org in .hg/hgrc. This CL is coming in from graham4king@gmail.com. Can you sign the CLA with that e-mail address, or alternatively recreate the CL with the graham@gkgk.org address? Thanks. Ian > On 14-02-27 09:09 AM, josharian@gmail.com wrote: >> LGTM but will wait for rsc >> >> Thanks, Graham! >> >> Will you sign the CLA linked to from the bottom of >> http://golang.org/doc/contribute.html? >> >> >> >> >> https://codereview.appspot.com/69320043/diff/20001/src/cmd/ld/dwarf.c >> File src/cmd/ld/dwarf.c (right): >> >> https://codereview.appspot.com/69320043/diff/20001/src/cmd/ld/dwarf.c#newcode... >> src/cmd/ld/dwarf.c:1415: OPCODE_BASE = 10 >> A comment here would be nice, something to the effect of "DWARF 2 has 9 >> standard opcodes". Note that DWARF 3 has 12 standard opcodes, so the >> DWARF version matters. >> >> https://codereview.appspot.com/69320043/ > > -- > You received this message because you are subscribed to the Google Groups "golang-codereviews" group. > To unsubscribe from this group and stop receiving emails from it, send an email to golang-codereviews+unsubscribe@googlegroups.com. > For more options, visit https://groups.google.com/groups/opt_out.
Sign in to reply to this message.
Huh. It shows up as graham4king@gmail.com when I clpatch. Not sure how to fix that. On Thu, Feb 27, 2014 at 9:18 AM, Graham King <graham@gkgk.org> wrote: > I signed the CLA in May 2012 as graham@gkgk.org, for this issue: http://code.google.com/p/go/issues/detail?id=3339 > > I use graham@gkgk.org in .hg/hgrc. > > > On 14-02-27 09:09 AM, josharian@gmail.com wrote: >> LGTM but will wait for rsc >> >> Thanks, Graham! >> >> Will you sign the CLA linked to from the bottom of >> http://golang.org/doc/contribute.html? >> >> >> >> >> https://codereview.appspot.com/69320043/diff/20001/src/cmd/ld/dwarf.c >> File src/cmd/ld/dwarf.c (right): >> >> https://codereview.appspot.com/69320043/diff/20001/src/cmd/ld/dwarf.c#newcode... >> src/cmd/ld/dwarf.c:1415: OPCODE_BASE = 10 >> A comment here would be nice, something to the effect of "DWARF 2 has 9 >> standard opcodes". Note that DWARF 3 has 12 standard opcodes, so the >> DWARF version matters. >> >> https://codereview.appspot.com/69320043/
Sign in to reply to this message.
Processed. Feel free to send us a CL adding graham@gkgk.org as an alternate email to CONTRIBUTORS and AUTHORS if you'd like. On Thu, Feb 27, 2014 at 9:31 AM, Graham King <graham@gkgk.org> wrote: > Signed as graham4king@gmail.com. > > On 14-02-27 09:24 AM, Ian Lance Taylor wrote: > > > > This CL is coming in from graham4king@gmail.com. Can you sign the CLA > > with that e-mail address, or alternatively recreate the CL with the > > graham@gkgk.org address? Thanks. > > > > Ian > > > > -- > You received this message because you are subscribed to the Google Groups > "golang-codereviews" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to golang-codereviews+unsubscribe@googlegroups.com. > For more options, visit https://groups.google.com/groups/opt_out. >
Sign in to reply to this message.
R=iant@golang.org (assigned by josharian@gmail.com)
Sign in to reply to this message.
Ian, I was hoping to get a second look from someone with deeper DWARF experience before I submit.
Sign in to reply to this message.
LGTM there is no one else
Sign in to reply to this message.
*** Submitted as https://code.google.com/p/go/source/detail?r=7611e98a94c8 *** cmd/ld: DWARF opcode base to 10 DWARF 2 has 9 standard opcodes, so dwarfdump expects us to use an opcode base of at least 10. Previously we used 5. Discussion: https://groups.google.com/forum/#!topic/golang-dev/d-BqpPgalzc LGTM=josharian, rsc R=golang-codereviews, gobot, rsc, josharian, iant, bradfitz CC=golang-codereviews https://codereview.appspot.com/69320043 Committer: Josh Bleecher Snyder <josharian@gmail.com>
Sign in to reply to this message.
This CL appears to have broken the dragonfly-386 builder.
Sign in to reply to this message.
> This CL appears to have broken the dragonfly-386 builder. > > https://codereview.appspot.com/69320043/ Nope: 2014/03/03 11:16:18 Get http://127.0.0.1:4729/edit/Test: dial tcp 127.0.0.1:4729: i/o timeout
Sign in to reply to this message.
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
