Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(35)

Issue 6931046: code review 6931046: cmd/fix: Add keys to printer.Config composite literals. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 9 months ago by cahooon
Modified:
9 years, 9 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

cmd/fix: Add keys to printer.Config composite literals. Fixes issue 4499.

Patch Set 1 #

Patch Set 2 : diff -r 2888e5323790 https://code.google.com/p/go #

Patch Set 3 : diff -r 2888e5323790 https://code.google.com/p/go #

Patch Set 4 : diff -r 2888e5323790 https://code.google.com/p/go #

Patch Set 5 : diff -r 2888e5323790 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -0 lines) Patch
A src/cmd/fix/printerconfig.go View 1 2 3 4 1 chunk +61 lines, -0 lines 0 comments Download
A src/cmd/fix/printerconfig_test.go View 1 2 3 4 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 5
cahooon
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
9 years, 9 months ago (2012-12-11 19:30:48 UTC) #1
cahooon
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 9 months ago (2012-12-11 19:41:09 UTC) #2
cahooon
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 9 months ago (2012-12-11 19:57:18 UTC) #3
rsc
LGTM Thanks.
9 years, 9 months ago (2012-12-16 23:38:27 UTC) #4
rsc
9 years, 9 months ago (2012-12-17 00:31:50 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=682625af5e48 ***

cmd/fix: Add keys to printer.Config composite literals.

Fixes issue 4499.

R=rsc
CC=golang-dev
https://codereview.appspot.com/6931046

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b