Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(554)

Issue 6931045: Reorg test code per Kapil comments

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by rharding
Modified:
11 years, 4 months ago
Reviewers:
hazmat, mp+139240
Visibility:
Public.

Description

Reorg test code per Kapil comments - rm tests/jobs - move tests/utils to test_utils - mv tests/test_views to views/tests/ - mv the misc views (home/search/) to views/misc.py - move views/tests/test_mainviews to views/tests/test_misc - mv tests to testing for test helpers https://code.launchpad.net/~rharding/charmworld/test_reorg/+merge/139240 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -187 lines) Patch
M Makefile View 1 chunk +2 lines, -2 lines 0 comments Download
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M charmworld/test_utils.py View 2 chunks +23 lines, -1 line 0 comments Download
D charmworld/tests/test_utils/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D charmworld/tests/test_utils/test_ini.py View 1 chunk +0 lines, -26 lines 0 comments Download
D charmworld/tests/test_views/test_mainviews.py View 1 chunk +0 lines, -23 lines 0 comments Download
M charmworld/views/__init__.py View 2 chunks +0 lines, -133 lines 0 comments Download
M charmworld/views/charms.py View 3 chunks +3 lines, -3 lines 0 comments Download
A charmworld/views/misc.py View 1 chunk +133 lines, -0 lines 0 comments Download
A charmworld/views/tests/test_misc.py View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 2
rharding
Please take a look.
11 years, 4 months ago (2012-12-11 15:57:15 UTC) #1
hazmat
11 years, 4 months ago (2012-12-11 21:33:56 UTC) #2
looks good, we should probably separate out search views into a separate module,
but that can come later. thanks for the test re-jig.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b