Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7332)

Issue 6929057: Add support for jitsu deploy-to.

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by frankban
Modified:
11 years, 4 months ago
Reviewers:
mp+139526
Visibility:
Public.

Description

Add support for jitsu deploy-to. The charm already worked well when deployed in the bootstrap node using the 'jitsu deploy-to' command. This branch adds a test for this behavior. Other changes: Slightly simplified how the staging option is retrieved in the start hook. Fixed tests by changing the juju-gui upstart configuration file. Before this change it was not possible for upstart to correctly stop the juju-gui service, because upstart itself was not able to keep track of the PID. Fixed the install hook: it was not idempotent (and the tests were broken for this reason too). https://code.launchpad.net/~frankban/charms/precise/juju-gui/bug-1086788-jitsu-deploy-to/+merge/139526 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Add support for jitsu deploy-to. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -31 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M config/juju-gui.conf.template View 1 chunk +19 lines, -2 lines 0 comments Download
M hooks/install View 2 chunks +11 lines, -6 lines 0 comments Download
M hooks/start View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/deploy.test View 5 chunks +50 lines, -20 lines 0 comments Download
M tests/test_utils.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5
frankban
Please take a look.
11 years, 4 months ago (2012-12-12 17:45:00 UTC) #1
matthew.scott
Approved for me, no additional changes. Thanks for the changes, I think there's a lot ...
11 years, 4 months ago (2012-12-12 19:01:42 UTC) #2
gary.poster
Land as is. Looks great, Francesco. Thank you. Gary
11 years, 4 months ago (2012-12-12 20:21:35 UTC) #3
frankban
Hi Gary and Matthew, thanks for the reviews.
11 years, 4 months ago (2012-12-13 08:42:16 UTC) #4
frankban
11 years, 4 months ago (2012-12-13 08:43:10 UTC) #5
*** Submitted:

Add support for jitsu deploy-to.

The charm already worked well when deployed in the bootstrap node using
the 'jitsu deploy-to' command. This branch adds a test for this behavior.

Other changes:

Slightly simplified how the staging option is retrieved in the start hook.

Fixed tests by changing the juju-gui upstart configuration file. Before
this change it was not possible for upstart to correctly stop the juju-gui
service, because upstart itself was not able to keep track of the PID.

Fixed the install hook: it was not idempotent (and the tests were broken
for this reason too).

R=matthew.scott, gary.poster
CC=
https://codereview.appspot.com/6929057
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b