code review 6929049: fmt: fix %v of complex slice

fmt: fix %v of complex slice

Fixes issue 4525.

[rsc, 2012-12-11 16:43:01]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2012-12-11 16:47:08]

LGTM but typo in comment. Used to?
 On Dec 11, 2012 11:43 AM, <rsc@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> fmt: fix %v of complex slice
>
> Fixes issue 4525.
>
> Please review this at
https://codereview.appspot.**com/6929049/<https://codereview.appspot.com/6929...
>
> Affected files:
>   M src/pkg/fmt/fmt_test.go
>   M src/pkg/fmt/format.go
>
>
> Index: src/pkg/fmt/fmt_test.go
> ==============================**==============================**=======
> --- a/src/pkg/fmt/fmt_test.go
> +++ b/src/pkg/fmt/fmt_test.go
> @@ -476,6 +476,11 @@
>
>         // Used to crash because nByte didn't allow for a sign.
>         {"%b", int64(-1 << 63), "-**100000000000000000000000000000**
> 000000000000000000000000000000**0000"},
> +
> +       // Complex fmt to leave the plus flag set for future entries in
> the array
> +       // causing +2+0i and +3+0i instead of 2+0i and 3+0i.
> +       {"%v", []complex64{1, 2, 3}, "[(1+0i) (2+0i) (3+0i)]"},
> +       {"%v", []complex128{1, 2, 3}, "[(1+0i) (2+0i) (3+0i)]"},
>  }
>
>  func TestSprintf(t *testing.T) {
> Index: src/pkg/fmt/format.go
> ==============================**==============================**=======
> --- a/src/pkg/fmt/format.go
> +++ b/src/pkg/fmt/format.go
> @@ -428,6 +428,7 @@
>  func (f *fmt) fmt_c64(v complex64, verb rune) {
>         f.buf.WriteByte('(')
>         r := real(v)
> +       oldPlus := f.plus
>         for i := 0; ; i++ {
>                 switch verb {
>                 case 'e':
> @@ -447,6 +448,7 @@
>                 f.plus = true
>                 r = imag(v)
>         }
> +       f.plus = oldPlus
>         f.buf.Write(irparenBytes)
>  }
>
> @@ -454,6 +456,7 @@
>  func (f *fmt) fmt_c128(v complex128, verb rune) {
>         f.buf.WriteByte('(')
>         r := real(v)
> +       oldPlus := f.plus
>         for i := 0; ; i++ {
>                 switch verb {
>                 case 'e':
> @@ -473,5 +476,6 @@
>                 f.plus = true
>                 r = imag(v)
>         }
> +       f.plus = oldPlus
>         f.buf.Write(irparenBytes)
>  }
>
>
>

[rsc, 2012-12-11 16:49:44]

*** Submitted as https://code.google.com/p/go/source/detail?r=835576f9bf0e ***

fmt: fix %v of complex slice

Fixes issue 4525.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/6929049