code review 6929048: math/big: add SetUint64 and Uint64 functions to *Int

math/big: add SetUint64 and Uint64 functions to *Int

Implementation is mostly identical to passing a non-negative int64 to
SetInt64, and calling Int64 with a non-negative value in the *Int.
Fixes issue 4389.

[Luit, 2012-12-11 16:31:26]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[rsc, 2012-12-11 16:45:34]

Looks good but please add a test using String too.
The routines are clearly correct but the test is only checking that Uint64 and
SetUint64 agree with each other. Testing against String checks that they agree
with the rest of the library too.

https://codereview.appspot.com/6929048/diff/5001/src/pkg/math/big/int_test.go
File src/pkg/math/big/int_test.go (right):

https://codereview.appspot.com/6929048/diff/5001/src/pkg/math/big/int_test.go...
src/pkg/math/big/int_test.go:1158: }
Add

str := fmt.Sprint(testVal)
strOut := in.String()
if strOut != str {
    t.Errorf("#%d.String got %s want %s", i, strOut, str)
}

[Luit, 2012-12-11 17:02:53]

Hello golang-dev@googlegroups.com, rsc@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[rsc, 2012-12-11 17:14:13]

LGTM

[rsc, 2012-12-11 17:19:19]

*** Submitted as https://code.google.com/p/go/source/detail?r=954a79ee3ea8 ***

math/big: add SetUint64 and Uint64 functions to *Int

Implementation is mostly identical to passing a non-negative int64 to
SetInt64, and calling Int64 with a non-negative value in the *Int.
Fixes issue 4389.

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/6929048

Committer: Russ Cox <rsc@golang.org>