code review 6927043: cmd/gc: remove bad check for BADWIDTH

cmd/gc: remove bad check for BADWIDTH

This check for BADWIDTH might happen while in defercheckwidth, making it raise errors for non-erroneous situations.

Fixes issue 4495.

[DMorsing, 2012-12-10 22:02:32]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[rsc, 2012-12-10 22:35:13]

I believe this silences the error, but the reason for checking is that
a few lines later it says:
    n->xoffset = f1->width;

Does something else come back and fix up n->xoffset?

Russ

[DMorsing, 2012-12-10 23:06:57]

On 2012/12/10 22:35:13, rsc wrote:
> I believe this silences the error, but the reason for checking is that
> a few lines later it says:
>     n->xoffset = f1->width;
> 
> Does something else come back and fix up n->xoffset?
> 
> Russ

xoffset is overwritten by the function that calls looktypedot. After that, all
width references are through the type, which gets updated when resumecheckwidth
is called.

[rsc, 2012-12-10 23:09:41]

LGTM

[DMorsing, 2012-12-11 16:36:16]

*** Submitted as https://code.google.com/p/go/source/detail?r=854744b0b82b ***

cmd/gc: remove bad check for BADWIDTH

This check for BADWIDTH might happen while in defercheckwidth, making it raise
errors for non-erroneous situations.

Fixes issue 4495.

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/6927043