Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(195)

Issue 6925056: code review 6925056: misc/dashboard: don't email about netbsd failures (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by bradfitz
Modified:
11 years, 3 months ago
Reviewers:
CC:
iant, rsc, golang-dev
Visibility:
Public.

Description

misc/dashboard: don't email about netbsd failures Too flaky.

Patch Set 1 #

Patch Set 2 : diff -r 3d0bfd549c48 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 3d0bfd549c48 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r 3af6f955dc02 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 3af6f955dc02 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M misc/dashboard/app/build/notify.go View 1 2 3 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 9
bradfitz
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 3 months ago (2012-12-12 18:59:38 UTC) #1
bradfitz
s/that/which/ probably (preemptive defensive response) On Wed, Dec 12, 2012 at 10:59 AM, <bradfitz@golang.org> wrote: ...
11 years, 3 months ago (2012-12-12 19:02:06 UTC) #2
iant
LGTM
11 years, 3 months ago (2012-12-12 19:02:43 UTC) #3
rsc
NOT LGTM
11 years, 3 months ago (2012-12-12 19:08:03 UTC) #4
bradfitz
On Wed, Dec 12, 2012 at 11:08 AM, Russ Cox <rsc@golang.org> wrote: > NOT LGTM ...
11 years, 3 months ago (2012-12-12 19:09:28 UTC) #5
rsc
https://codereview.appspot.com/6925056/diff/5001/misc/dashboard/app/build/notify.go File misc/dashboard/app/build/notify.go (right): https://codereview.appspot.com/6925056/diff/5001/misc/dashboard/app/build/notify.go#newcode40 misc/dashboard/app/build/notify.go:40: // TODO(adg): implement notifications for packages The if statement ...
11 years, 3 months ago (2012-12-12 19:10:04 UTC) #6
bradfitz
Hello iant@golang.org, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
11 years, 3 months ago (2012-12-12 19:14:49 UTC) #7
rsc
LGTM
11 years, 3 months ago (2012-12-12 19:21:26 UTC) #8
bradfitz
11 years, 3 months ago (2012-12-12 19:33:06 UTC) #9
*** Submitted as https://code.google.com/p/go/source/detail?r=8f2748bfb556 ***

misc/dashboard: don't email about netbsd failures

Too flaky.

R=iant, rsc
CC=golang-dev
https://codereview.appspot.com/6925056
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b