code review 6924044: mime/multipart: allow setting the Writer boundary

mime/multipart: allow setting the Writer boundary

Fixes issue 4490

[bradfitz, 2012-12-10 21:02:02]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2012-12-10 21:27:55]

LGTM

https://codereview.appspot.com/6924044/diff/4001/src/pkg/mime/multipart/write...
File src/pkg/mime/multipart/writer.go (right):

https://codereview.appspot.com/6924044/diff/4001/src/pkg/mime/multipart/write...
src/pkg/mime/multipart/writer.go:52: if b < 128 {
Can drop the if. If b >= 128 the code below will work and there's no need for a
fast path.

https://codereview.appspot.com/6924044/diff/4001/src/pkg/mime/multipart/write...
src/pkg/mime/multipart/writer.go:53: if b >= 'A' && b <= 'Z' || b >= 'a' && b <=
'z' || b >= '0' && b <= '9' {
Elsewhere in the tree we've used 'A' <= b for the left half of such a range
check. 3x.

[bradfitz, 2012-12-10 21:30:47]

*** Submitted as https://code.google.com/p/go/source/detail?r=11d696585699 ***

mime/multipart: allow setting the Writer boundary

Fixes issue 4490

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/6924044