Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1014)

Issue 6923055: code review 6923055: net/http: follow certain redirects after POST requests (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by bradfitz
Modified:
11 years, 3 months ago
Reviewers:
CC:
golang-dev, rsc
Visibility:
Public.

Description

net/http: follow certain redirects after POST requests Fixes issue 4145

Patch Set 1 #

Patch Set 2 : diff -r 3d0bfd549c48 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 3d0bfd549c48 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r 614c33a2ccd2 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -6 lines) Patch
src/pkg/net/http/client.go View 1 7 chunks +22 lines, -6 lines 0 comments Download
src/pkg/net/http/client_test.go View 1 2 chunks +47 lines, -0 lines 0 comments Download

Messages

Total messages: 3
bradfitz
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 3 months ago (2012-12-11 21:42:01 UTC) #1
rsc
LGTM https://codereview.appspot.com/6923055/diff/5001/src/pkg/net/http/client.go File src/pkg/net/http/client.go (right): https://codereview.appspot.com/6923055/diff/5001/src/pkg/net/http/client.go#newcode234 src/pkg/net/http/client.go:234: // TODO: if/when we add cookie support, the ...
11 years, 3 months ago (2012-12-12 03:57:36 UTC) #2
bradfitz
11 years, 3 months ago (2012-12-12 19:10:03 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=3af6f955dc02 ***

net/http: follow certain redirects after POST requests

Fixes issue 4145

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/6923055
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b