Issue 6923051: code review 6923051: A+C: Brian Ketelsen and Miquel Sabaté Solà (individua...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6923051: code review 6923051: A+C: Brian Ketelsen and Miquel Sabaté Solà (individua... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by rsc

Modified:
12 years, 3 months ago

Reviewers:

CC:
golang-dev, bradfitz

Visibility:
Public.

Description

A+C: Brian Ketelsen and Miquel Sabaté Solà (individual CLA × 2)

Patch Set 1 #

Patch Set 2 : diff -r 21d62bd46e78 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 21d62bd46e78 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 835576f9bf0e https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 835576f9bf0e https://go.googlecode.com/hg/ #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	AUTHORS	View	1 2 3	2 chunks	+2 lines, -0 lines	0 comments	Download
	M	CONTRIBUTORS	View	1 2 3	3 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 3 months ago (2012-12-11 15:45:15 UTC) #1

rsc

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.

12 years, 3 months ago (2012-12-11 16:53:18 UTC) #2

bradfitz

LGTM On Tue, Dec 11, 2012 at 11:53 AM, <rsc@golang.org> wrote: > Hello golang-dev@googlegroups.com (cc: ...

12 years, 3 months ago (2012-12-11 16:54:54 UTC) #3

rsc

12 years, 3 months ago (2012-12-11 17:02:12 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=6e8595cf6d39 ***

A+C: Brian Ketelsen and Miquel Sabaté Solà (individual CLA × 2)

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/6923051

Expand All Messages | Collapse All Messages