Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(726)

Issue 6923049: code review 6923049: encoding/csv: add Error method to Writer (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by ryanslade
Modified:
8 years, 6 months ago
Reviewers:
rsc
CC:
bradfitz, rsc, golang-dev
Visibility:
Public.

Description

encoding/csv: add Error method to Writer Fixed issue 3931

Patch Set 1 #

Patch Set 2 : diff -r 7b9e9fc59eb5 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 7b9e9fc59eb5 https://code.google.com/p/go/ #

Total comments: 3

Patch Set 4 : diff -r 3a97cf1c51ba https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -0 lines) Patch
M src/pkg/encoding/csv/writer.go View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M src/pkg/encoding/csv/writer_test.go View 1 2 chunks +28 lines, -0 lines 0 comments Download

Messages

Total messages: 11
ryanslade
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
9 years, 6 months ago (2012-12-11 10:49:00 UTC) #1
bradfitz
(thinking aloud) Could we "break" the Go 1 API contract and just an error return ...
9 years, 6 months ago (2012-12-11 17:10:18 UTC) #2
bradfitz
https://codereview.appspot.com/6923049/diff/5001/src/pkg/encoding/csv/writer.go File src/pkg/encoding/csv/writer.go (right): https://codereview.appspot.com/6923049/diff/5001/src/pkg/encoding/csv/writer.go#newcode95 src/pkg/encoding/csv/writer.go:95: // To check if an error occured during the ...
9 years, 6 months ago (2012-12-11 17:13:39 UTC) #3
ryanslade
To be honest, I was thinking the same thing. The only people likely to use ...
9 years, 6 months ago (2012-12-11 17:14:34 UTC) #4
rsc
I understand that it's tempting to break the API contract, and also it is unlikely ...
9 years, 6 months ago (2012-12-11 17:16:30 UTC) #5
ryanslade
Hello bradfitz@golang.org, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 6 months ago (2012-12-11 17:27:30 UTC) #6
ryanslade
On 2012/12/11 17:27:30, ryanslade wrote: > Hello mailto:bradfitz@golang.org, mailto:rsc@golang.org (cc: mailto:golang-dev@googlegroups.com), > > Please take ...
9 years, 6 months ago (2012-12-11 17:28:32 UTC) #7
rsc
LGTM
9 years, 6 months ago (2012-12-11 17:30:13 UTC) #8
rsc
It looks like you need to complete a CLA as described at http://golang.org/doc/contribute.html#copyright Please do ...
9 years, 6 months ago (2012-12-11 17:31:01 UTC) #9
ryanslade
On 2012/12/11 17:31:01, rsc wrote: > It looks like you need to complete a CLA ...
9 years, 6 months ago (2012-12-11 17:39:52 UTC) #10
rsc
9 years, 6 months ago (2012-12-11 18:29:27 UTC) #11
*** Submitted as https://code.google.com/p/go/source/detail?r=91e7645fae10 ***

encoding/csv: add Error method to Writer

Fixed issue 3931

R=bradfitz, rsc
CC=golang-dev
https://codereview.appspot.com/6923049

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b