code review 6922050: go.net/proxy: correctly sets IPv4 addresses in socks5 r...

go.net/proxy: correctly sets IPv4 addresses in socks5 request now

net.ParseIP(host) always returns a 16-byte array, we should convert
it into 4-byte array before copy it to the IP field if it is a IPv4
address.

[raptium, 2012-12-12 06:02:30]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go.net

[raptium, 2012-12-12 06:09:41]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc, 2012-12-12 19:34:01]

A test would be nice but I'm unfamiliar with this repo. Do we have tests for
this package?

https://codereview.appspot.com/6922050/diff/2002/proxy/socks5.go
File proxy/socks5.go (right):

https://codereview.appspot.com/6922050/diff/2002/proxy/socks5.go#newcode147
proxy/socks5.go:147: buf = append(buf, []byte(ipv4)...)
ip = ipv4
and then the append can be done below where it used to be.

Also the []byte() conversion is not necessary (I know it was in the original).

[raptium, 2012-12-13 06:17:38]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[mikio, 2012-12-15 04:48:40]

Could you please add a test.

Also please change the CL description.
PerseIP does return a slice, not an array.
The doc fix is in progress:  https://codereview.appspot.com/6930047/