Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(220)

Issue 6922050: code review 6922050: go.net/proxy: correctly sets IPv4 addresses in socks5 r...

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 8 months ago by raptium
Modified:
9 years, 8 months ago
Reviewers:
rsc, mikio
CC:
golang-dev
Visibility:
Public.

Description

go.net/proxy: correctly sets IPv4 addresses in socks5 request now net.ParseIP(host) always returns a 16-byte array, we should convert it into 4-byte array before copy it to the IP field if it is a IPv4 address.

Patch Set 1 #

Patch Set 2 : diff -r 3f49abc52b3c https://code.google.com/p/go.net #

Patch Set 3 : diff -r 3f49abc52b3c https://code.google.com/p/go.net #

Total comments: 1

Patch Set 4 : diff -r 3f49abc52b3c https://code.google.com/p/go.net #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M proxy/socks5.go View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5
raptium
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.net
9 years, 8 months ago (2012-12-12 06:02:30 UTC) #1
raptium
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 8 months ago (2012-12-12 06:09:41 UTC) #2
rsc
A test would be nice but I'm unfamiliar with this repo. Do we have tests ...
9 years, 8 months ago (2012-12-12 19:34:01 UTC) #3
raptium
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 8 months ago (2012-12-13 06:17:38 UTC) #4
mikio
9 years, 8 months ago (2012-12-15 04:48:40 UTC) #5
Could you please add a test.

Also please change the CL description.
PerseIP does return a slice, not an array.
The doc fix is in progress:  https://codereview.appspot.com/6930047/
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b