Add ingest pipeline for charm jenkins results.

Add ingest pipeline for charm jenkins results.

This merely stores any results and artifacts for a charm jenkins test. Saving 
display for another branch due to trunk changes and buildout issues which need 
resolving separately.

https://code.launchpad.net/~hazmat/charmworld/charm-test-results/+merge/139200

(do not edit description out of merge proposal)

[hazmat, 2012-12-11 13:33:32]

Please take a look.

[hazmat, 2012-12-11 13:54:14]

Please take a look.

[rharding, 2012-12-11 14:00:22]

https://codereview.appspot.com/6922046/diff/1/charmworld/jobs/jenkins.py
File charmworld/jobs/jenkins.py (right):

https://codereview.appspot.com/6922046/diff/1/charmworld/jobs/jenkins.py#newc...
charmworld/jobs/jenkins.py:51: charm_result_url = JENKINS_QA_URL.format(
Since the URL string is blind, defined elsewhere, could it be done with named
properties instead so that it's easier to get the right values in without mixing
order on accident?

https://codereview.appspot.com/6922046/diff/1/scripts/ingest
File scripts/ingest (right):

https://codereview.appspot.com/6922046/diff/1/scripts/ingest#newcode6
scripts/ingest:6: PYTHON_BIN=${PYTHON_BIN:=python}
I think this was tweaked by Aaron's work so that it pointed at the buildout
bin/py file instead?

https://codereview.appspot.com/6922046/diff/1/scripts/ingest#newcode43
scripts/ingest:43: #$PROJECT_DIR/scripts/clear-cache
Did you mean to not clear the cache? Was this just debugging and should be
uncommented?

https://codereview.appspot.com/6922046/diff/1/scripts/reset-db
File scripts/reset-db (right):

https://codereview.appspot.com/6922046/diff/1/scripts/reset-db#newcode34
scripts/reset-db:34: #log.info("Clearing charm directories @ %s",
config.CHARM_DIR)
Same here, is this meant to be left commented out?

[rharding, 2012-12-11 14:06:02]

bah, forgot the lgtm aside from the comments.

[hazmat, 2012-12-11 14:51:30]

On 2012/12/11 14:00:22, rharding wrote:
> https://codereview.appspot.com/6922046/diff/1/charmworld/jobs/jenkins.py
> File charmworld/jobs/jenkins.py (right):
> 
>
https://codereview.appspot.com/6922046/diff/1/charmworld/jobs/jenkins.py#newc...
> charmworld/jobs/jenkins.py:51: charm_result_url = JENKINS_QA_URL.format(
> Since the URL string is blind, defined elsewhere, could it be done with named
> properties instead so that it's easier to get the right values in without
mixing
> order on accident?

sounds good.

> 
> https://codereview.appspot.com/6922046/diff/1/scripts/ingest
> File scripts/ingest (right):
> 
> https://codereview.appspot.com/6922046/diff/1/scripts/ingest#newcode6
> scripts/ingest:6: PYTHON_BIN=${PYTHON_BIN:=python}
> I think this was tweaked by Aaron's work so that it pointed at the buildout
> bin/py file instead?
> 

just merged aaron's work, which actually is based on dev-ingest setting the
shell variable which this script respects.

 https://codereview.appspot.com/6922046/diff/1/scripts/ingest#newcode43
> scripts/ingest:43: #$PROJECT_DIR/scripts/clear-cache
> Did you mean to not clear the cache? Was this just debugging and should be
> uncommented?

The cache clearing script is specific to the prod setup (nginx service) which we
don't really account for in the buildout atm, so i was just disabling till we do
so.


> 
> https://codereview.appspot.com/6922046/diff/1/scripts/reset-db
> File scripts/reset-db (right):
> 
> https://codereview.appspot.com/6922046/diff/1/scripts/reset-db#newcode34
> scripts/reset-db:34: #log.info("Clearing charm directories @ %s",
> config.CHARM_DIR)
> Same here, is this meant to be left commented out?

replaced script with the shell script version that was under discussion that
doesn't attempt to clear out the charm directories.


Thanks for the review.