Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2133)

Issue 6921049: Add a HACKING.txt file.

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by teknico
Modified:
11 years, 4 months ago
Reviewers:
mp+139484
Visibility:
Public.

Description

Add a HACKING.txt file. Move testing docs from the README.txt file to a new HACKING.txt, put deploying docs in README.txt . https://code.launchpad.net/~teknico/charms/precise/juju-gui/1089028-add-hacking-file/+merge/139484 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 4

Patch Set 2 : Add a HACKING.txt file. #

Patch Set 3 : Add a HACKING.txt file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M HACKING.txt View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8
teknico
Please take a look.
11 years, 4 months ago (2012-12-12 15:12:39 UTC) #1
gary.poster
Land with changes. Thank you Nicola. Looks good. Gary https://codereview.appspot.com/6921049/diff/1/HACKING.txt File HACKING.txt (right): https://codereview.appspot.com/6921049/diff/1/HACKING.txt#newcode12 HACKING.txt:12: ...
11 years, 4 months ago (2012-12-12 21:26:32 UTC) #2
benji
Looks good. https://codereview.appspot.com/6921049/diff/1/HACKING.txt File HACKING.txt (right): https://codereview.appspot.com/6921049/diff/1/HACKING.txt#newcode12 HACKING.txt:12: Unit tests On 2012/12/12 21:26:32, gary.poster wrote: ...
11 years, 4 months ago (2012-12-12 22:08:10 UTC) #3
gary.poster
On 2012/12/12 22:08:10, benji wrote: > Looks good. > > https://codereview.appspot.com/6921049/diff/1/HACKING.txt > File HACKING.txt (right): ...
11 years, 4 months ago (2012-12-12 22:22:50 UTC) #4
teknico
gary.poster wrote: > It's the proper English way of capitalizing titles. Take it from > ...
11 years, 4 months ago (2012-12-13 12:38:37 UTC) #5
teknico
*** Submitted: Add a HACKING.txt file. Move testing docs from the README.txt file to a ...
11 years, 4 months ago (2012-12-13 13:01:44 UTC) #6
benji
On Wed, Dec 12, 2012 at 10:22 PM, <gary.poster@canonical.com> wrote: > It's the proper English ...
11 years, 4 months ago (2012-12-13 13:17:29 UTC) #7
teknico
11 years, 4 months ago (2012-12-13 13:51:36 UTC) #8
*** Submitted:

Add a HACKING.txt file.

Move testing docs from the README.txt file to a new HACKING.txt, put deploying
docs in README.txt .

R=benji
CC=
https://codereview.appspot.com/6921049
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b