Issue 6920057: code review 6920057: spec: more explicit comments for constant expression ex...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6920057: code review 6920057: spec: more explicit comments for constant expression ex... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by gri

Modified:
12 years, 3 months ago

Reviewers:

CC:
rsc, iant, golang-dev

Visibility:
Public.

Description

spec: more explicit comments for constant expression examples Fixes issue 3814.

Patch Set 2 : diff -r d09a8b21b517 https://code.google.com/p/go #

Patch Set 3 : diff -r d09a8b21b517 https://code.google.com/p/go #

Patch Set 4 : diff -r d09a8b21b517 https://code.google.com/p/go #

Total comments: 4

Patch Set 5 : diff -r d09a8b21b517 https://code.google.com/p/go #

Patch Set 6 : diff -r d09a8b21b517 https://code.google.com/p/go #

Patch Set 7 : diff -r d09a8b21b517 https://code.google.com/p/go #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -8 lines)			Patch
	M	doc/go_spec.html	View	1 2 3 4	4 chunks	+8 lines, -8 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

gri

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

12 years, 3 months ago (2012-12-12 21:39:24 UTC) #1

iant

https://codereview.appspot.com/6920057/diff/3/doc/go_spec.html File doc/go_spec.html (right): https://codereview.appspot.com/6920057/diff/3/doc/go_spec.html#newcode3738 doc/go_spec.html:3738: uint(-1) // -1 overflows uint I think the "cannot ...

12 years, 3 months ago (2012-12-12 21:51:14 UTC) #2

gri

Hello rsc@golang.org, iant@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

12 years, 3 months ago (2012-12-12 22:04:14 UTC) #3

gri

12 years, 3 months ago (2012-12-12 22:25:46 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=8b89b6326704 ***

spec: more explicit comments for constant expression examples

Fixes issue 3814.

R=rsc, iant
CC=golang-dev
https://codereview.appspot.com/6920057

https://codereview.appspot.com/6920057/diff/3/doc/go_spec.html
File doc/go_spec.html (right):

https://codereview.appspot.com/6920057/diff/3/doc/go_spec.html#newcode3738
doc/go_spec.html:3738: uint(-1)     // -1 overflows uint
On 2012/12/12 21:51:14, iant wrote:
> I think the "cannot be represented as" that you had before may be better here.

Done.

https://codereview.appspot.com/6920057/diff/3/doc/go_spec.html#newcode3753
doc/go_spec.html:3753: uint8(^1)  // illegal: same as uint8(-2), -2 overflows
uint8
On 2012/12/12 21:51:14, iant wrote:
> Again I think "out of range" may be better.

Changed to "cannot be represented as" to be consistent.

PS: If "out of range" is better here, than "out of range" should also be better
above (and "out of range" is closer to "overflows" than "cannot be represented".
The "cannot be represented" does not say why, while the "overflows" or "out of
range" comment does. Either way, changed back for consistent phrasing.

Expand All Messages | Collapse All Messages