code review 6920051: cmd/gc: Give better line numbers for errors in composit...

cmd/gc: Give better line numbers for errors in composite literals.

Credit to Russ for suggesting this fix.

Fixes issue 3925.

[DMorsing, 2012-12-11 22:51:18]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[fss, 2012-12-12 02:19:26]

Just one documentation glitch.

https://codereview.appspot.com/6920051/diff/5001/src/cmd/gc/go.y
File src/cmd/gc/go.y (right):

https://codereview.appspot.com/6920051/diff/5001/src/cmd/gc/go.y#newcode983
src/cmd/gc/go.y:983: // introduce an anchor node to give the correct line.
s/introduce/Introduce/

[rsc, 2012-12-12 03:53:44]

LGTM

https://codereview.appspot.com/6920051/diff/5001/src/cmd/gc/go.y
File src/cmd/gc/go.y (right):

https://codereview.appspot.com/6920051/diff/5001/src/cmd/gc/go.y#newcode983
src/cmd/gc/go.y:983: // introduce an anchor node to give the correct line.
s/anchor/wrapper/?
I don't know what anchor means here.

[DMorsing, 2012-12-12 15:43:25]

https://codereview.appspot.com/6920051/diff/5001/src/cmd/gc/go.y
File src/cmd/gc/go.y (right):

https://codereview.appspot.com/6920051/diff/5001/src/cmd/gc/go.y#newcode983
src/cmd/gc/go.y:983: // introduce an anchor node to give the correct line.
On 2012/12/12 02:19:26, fss wrote:
> s/introduce/Introduce/

Done.

https://codereview.appspot.com/6920051/diff/5001/src/cmd/gc/go.y#newcode983
src/cmd/gc/go.y:983: // introduce an anchor node to give the correct line.
On 2012/12/12 03:53:44, rsc wrote:
> s/anchor/wrapper/?
> I don't know what anchor means here.

Done.

[DMorsing, 2012-12-12 15:44:01]

*** Submitted as https://code.google.com/p/go/source/detail?r=5529ef3e8a9b ***

cmd/gc: Give better line numbers for errors in composite literals.

Credit to Russ for suggesting this fix.

Fixes issue 3925.

R=golang-dev, franciscossouza, rsc
CC=golang-dev
https://codereview.appspot.com/6920051