Issue 69200043: code review 69200043: runtime, net: fixes from CL 68490043 review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 69200043: code review 69200043: runtime, net: fixes from CL 68490043 review (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by rsc

Modified:
11 years, 4 months ago

Reviewers:
minux1, gobot, iant

CC:
golang-codereviews, minux1, iant

Visibility:
Public.

runtime, net: fixes from CL 68490043 review These are mistakes in the first big NaCl CL.

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -8 lines)			Patch
M	src/pkg/runtime/arch_amd64.h	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
M	src/pkg/runtime/arch_amd64p32.h	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
M	src/pkg/runtime/runtime.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 5

rsc

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

11 years, 4 months ago (2014-02-26 15:20:57 UTC) #1

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=3512bf47df7e *** runtime, net: fixes from CL 68490043 review These are mistakes ...

11 years, 4 months ago (2014-02-26 17:21:34 UTC) #4

Message was sent while issue was closed.

This CL appears to have broken the freebsd-amd64 builder.