Issue 6912063: code review 6912063: syscall: let mkall.sh work on multiarch systems (like P...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6912063: code review 6912063: syscall: let mkall.sh work on multiarch systems (like P... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 7 months ago by bradfitz

Modified:
12 years, 7 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

syscall: let mkall.sh work on multiarch systems (like Precise)

Patch Set 2 : diff -r a7fe0ec318c1 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r a7fe0ec318c1 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r 34ec662d3e3c https://go.googlecode.com/hg/ #

Created: 12 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	src/pkg/syscall/mkall.sh	View	1 2 3	1 chunk	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 7 months ago (2012-12-10 17:30:34 UTC) #1

rsc

LGTM https://codereview.appspot.com/6912063/diff/4002/src/pkg/syscall/mkall.sh File src/pkg/syscall/mkall.sh (right): https://codereview.appspot.com/6912063/diff/4002/src/pkg/syscall/mkall.sh#newcode148 src/pkg/syscall/mkall.sh:148: unistd_h=`ls -1 /usr/include/asm/unistd_64.h /usr/include/x86_64-linux-gnu/asm/unistd_64.h 2>/dev/null | head -1` ...

12 years, 7 months ago (2012-12-11 16:11:42 UTC) #2

bradfitz

12 years, 7 months ago (2012-12-11 17:03:27 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=240812376302 ***

syscall: let mkall.sh work on multiarch systems (like Precise)

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/6912063

Expand All Messages | Collapse All Messages