Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1014)

Issue 6912045: code review 6912045: go.net/publicsuffix: new package. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by nigeltao
Modified:
11 years, 3 months ago
Reviewers:
CC:
rsc, volker.dobler, golang-dev
Visibility:
Public.

Description

go.net/publicsuffix: new package. The tables were generated by: go run gen.go -subset -version "subset of publicsuffix.org's effective_tld_names.dat, hg revision 05b11a8d1ace (2012-11-09)" >table.go go run gen.go -subset -version "subset of publicsuffix.org's effective_tld_names.dat, hg revision 05b11a8d1ace (2012-11-09)" -test >table_test.go The input data is subsetted so that code review is easier while still covering the interesting * and ! rules. A follow-up changelist will check in the unfiltered public suffix list. Update issue 1960.

Patch Set 1 #

Patch Set 2 : diff -r 3f49abc52b3c https://code.google.com/p/go.net #

Patch Set 3 : diff -r 3f49abc52b3c https://code.google.com/p/go.net #

Patch Set 4 : diff -r 3f49abc52b3c https://code.google.com/p/go.net #

Total comments: 6

Patch Set 5 : diff -r 3f49abc52b3c https://code.google.com/p/go.net #

Total comments: 1

Patch Set 6 : diff -r 3f49abc52b3c https://code.google.com/p/go.net #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1082 lines, -0 lines) Patch
A publicsuffix/gen.go View 1 2 3 4 1 chunk +439 lines, -0 lines 0 comments Download
A publicsuffix/list.go View 1 2 3 4 5 1 chunk +97 lines, -0 lines 0 comments Download
A publicsuffix/list_test.go View 1 1 chunk +271 lines, -0 lines 0 comments Download
A publicsuffix/table.go View 1 2 3 4 1 chunk +119 lines, -0 lines 0 comments Download
A publicsuffix/table_test.go View 1 1 chunk +156 lines, -0 lines 0 comments Download

Messages

Total messages: 6
nigeltao
Hello rsc@golang.org, dr.volker.dobler@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.net
11 years, 3 months ago (2012-12-07 07:18:03 UTC) #1
volker.dobler
LGTM Thanks for correcting my mistake in the kobe.jp case. https://codereview.appspot.com/6912045/diff/4002/publicsuffix/gen.go File publicsuffix/gen.go (right): https://codereview.appspot.com/6912045/diff/4002/publicsuffix/gen.go#newcode40 ...
11 years, 3 months ago (2012-12-09 00:13:02 UTC) #2
nigeltao
https://codereview.appspot.com/6912045/diff/4002/publicsuffix/gen.go File publicsuffix/gen.go (right): https://codereview.appspot.com/6912045/diff/4002/publicsuffix/gen.go#newcode40 publicsuffix/gen.go:40: nodeTypeParentOnly = 1 On 2012/12/09 00:13:02, volker.dobler wrote: > ...
11 years, 3 months ago (2012-12-09 23:49:02 UTC) #3
volker.dobler
LGTM
11 years, 3 months ago (2012-12-10 06:01:00 UTC) #4
rsc
LGTM I didn't read the implementation very carefully. If you and Volker agree, I'm happy. ...
11 years, 3 months ago (2012-12-12 04:02:35 UTC) #5
nigeltao
11 years, 3 months ago (2012-12-12 04:59:05 UTC) #6
*** Submitted as
https://code.google.com/p/go/source/detail?r=73ed64aa79d2&repo=net ***

go.net/publicsuffix: new package.

The tables were generated by:

go run gen.go -subset -version "subset of publicsuffix.org's
effective_tld_names.dat, hg revision 05b11a8d1ace (2012-11-09)"       >table.go

go run gen.go -subset -version "subset of publicsuffix.org's
effective_tld_names.dat, hg revision 05b11a8d1ace (2012-11-09)" -test
>table_test.go

The input data is subsetted so that code review is easier while still
covering the interesting * and ! rules. A follow-up changelist will
check in the unfiltered public suffix list.

Update issue 1960.

R=rsc, dr.volker.dobler
CC=golang-dev
https://codereview.appspot.com/6912045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b