Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(589)

Issue 6910055: Removed the interface and renamed get methods. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 4 months ago by dimitern
Modified:
8 years, 4 months ago
Reviewers:
mp+138989, rog
Visibility:
Public.

Description

Removed the interface and renamed get methods. This is a follow up to https://codereview.appspot.com/6877054/ As advised, removed the NovaService interface and turned it into an implementation. Also renamed all getXYZ*() methods to XYZ*() (without get). Renamed NovaService and NovaServiceSuite to Nova and NovaSuite, respectively. https://code.launchpad.net/~dimitern/goose/nova-testing-service2/+merge/138989 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Removed the interface and renamed get methods. #

Patch Set 3 : Removed the interface and renamed get methods. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -248 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
D testservices/novaservice/novaservice.go View 1 chunk +0 lines, -115 lines 0 comments Download
M testservices/novaservice/service.go View 1 22 chunks +43 lines, -42 lines 0 comments Download
M testservices/novaservice/service_http.go View 1 1 chunk +1 line, -1 line 0 comments Download
M testservices/novaservice/service_http_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M testservices/novaservice/service_test.go View 1 52 chunks +89 lines, -89 lines 0 comments Download

Messages

Total messages: 5
dimitern
Please take a look.
8 years, 4 months ago (2012-12-10 14:41:58 UTC) #1
dimitern
Please take a look.
8 years, 4 months ago (2012-12-10 14:51:07 UTC) #2
dimitern
On 2012/12/10 14:51:07, dimitern wrote: > Please take a look. As discussed on IRC, I ...
8 years, 4 months ago (2012-12-10 14:52:27 UTC) #3
dimitern
*** Submitted: Removed the interface and renamed get methods. This is a follow up to ...
8 years, 4 months ago (2012-12-10 14:53:46 UTC) #4
rog
8 years, 4 months ago (2012-12-10 15:17:18 UTC) #5
On 2012/12/10 14:41:58, dimitern wrote:
> Please take a look.

LGTM (with the thought that perhaps novaservice.NovaService is perhaps a little
longer than necessary)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b