Issue 69100045: code review 69100045: debug/macho: Define CPU constants for other common arch...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 69100045: code review 69100045: debug/macho: Define CPU constants for other common arch...

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by Robert Sesek (Google)

Modified:
11 years, 3 months ago

Reviewers:
gobot, iant

CC:
golang-codereviews, iant

Visibility:
Public.

Description

debug/macho: Define CPU constants for other common architectures for OS X/iOS.

Patch Set 1 #

Patch Set 2 : diff -r 65546d299e5a https://code.google.com/p/go #

Patch Set 3 : diff -r 65546d299e5a https://code.google.com/p/go #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -1 line)			Patch
	M	src/pkg/debug/macho/macho.go	View	1	1 chunk	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Robert Sesek (Google)

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

11 years, 3 months ago (2014-02-26 21:59:57 UTC) #1

iant

*** Submitted as https://code.google.com/p/go/source/detail?r=6065b50b2768 *** debug/macho: Define CPU constants for other common architectures for OS ...

11 years, 3 months ago (2014-02-28 03:11:10 UTC) #4

gobot

11 years, 3 months ago (2014-02-28 03:24:47 UTC) #5

This CL appears to have broken the windows-386-ec2 builder.

Expand All Messages | Collapse All Messages